Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing bellSound will not apply until bellStyle is changed to 'none' and back #904

Closed
Tyriar opened this issue Aug 19, 2017 · 2 comments
Closed

Changing bellSound will not apply until bellStyle is changed to 'none' and back #904

Tyriar opened this issue Aug 19, 2017 · 2 comments
Labels
type/bug Something is misbehaving
Milestone
3.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 19, 2017

FYI @npezza93
@Tyriar Tyriar added the type/bug Something is misbehaving label Aug 19, 2017
npezza93 added a commit to npezza93/xterm.js that referenced this issue Aug 19, 2017
@npezza93
When bellSound changes, update the bellAudioElements src
81cb308 
Fixes xtermjs#904
@npezza93 npezza93 mentioned this issue Aug 19, 2017
Merged
@Tyriar Tyriar added this to the 3.0.0 milestone Aug 19, 2017
@npezza93
Copy link
Contributor

npezza93 commented Sep 9, 2017

Hey @Tyriar, this can be closed now.

@Tyriar Tyriar closed this as completed Sep 9, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Sep 9, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@Tyriar @npezza93