Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate geometry option in favor of rows and cols #841

Closed
Tyriar opened this issue Aug 5, 2017 · 0 comments
Closed

Deprecate geometry option in favor of rows and cols #841

Tyriar opened this issue Aug 5, 2017 · 0 comments
Assignees
@Tyriar
Labels
breaking-change Breaks API and requires a major version bump type/debt Technical debt that could slow us down in the long run
Milestone
3.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 5, 2017

Found in #839, geometry should be removed imo as we already support rows and cols.

Keeping the options in sync with Terminal.rows/.cols would also be a good idea (property?).
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Aug 5, 2017
@Tyriar Tyriar added this to the 3.0.0 milestone Aug 5, 2017
@Tyriar Tyriar added the breaking-change Breaks API and requires a major version bump label Aug 8, 2017
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 9, 2017
@Tyriar
Remove geometry
0b90fea 
Fixes xtermjs#841
@Tyriar Tyriar mentioned this issue Nov 9, 2017
Merged
@Tyriar Tyriar self-assigned this Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
breaking-change Breaks API and requires a major version bump type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@Tyriar