Reverse color mode doesn't work when using a light theme

[Tyriar]

Downstream issue: microsoft/vscode#30024

JS has no knowledge of the background/foreground colors so it just uses .xterm-bg-color-15 and .xterm-color-0 for reversed unstyled text which should be the opposite on light themes.

[Tyriar]

Currently the default background/foreground is specified in the following CSS:

#terminal-container .terminal {
    background-color: #111;
    color: #fafafa;
}

[wavebeem]

Related: reverse video + red foreground on a light theme gives black text on a red background, rather than white text on a red background:

[Tyriar]

Yep, that's the same root cause. reverse on defaults is always assumed it was default black bg and default white fg..

[wavebeem]

Cool, just figured I'd add that since I wasn't 100% sure if it would affect the issue or not.

[jerch]

Imho this could be solved by enforcing a default class settings identifiable by the emulator so the emulator can reverse those settings when needed, e.g. .fg-default and .bg-default. This would involve copying the settings over from fb to bg and vice versa for reversed.
Might be even easier to enforce default reversed classes in the theme settings, e.g. .fg-reversed and .bg-reversed. With those the theme creator is responsible to set those values to a reversed scheme.

For all other non default color settings reversed should simply swap fg and bg settings, e.g. .xterm-bg-color-15 becomes .xterm-fg-color-15 and so on...

Btw as far as I know xterm simply reverses colors when higlighting with the mouse.

[Tyriar]

Yes we used to reverse color as well in vscode and I really liked it. Unfortunately it's not the easiest thing to support using the new SelectionManager.

[Tyriar]

This was fixed with the renderer update.

[dcalhoun]

This was fixed with the renderer update.

@Tyriar would you be able to elaborate on what commit/change was the fix? I'm still experiencing a similar issue that is outlined in jestjs/jest#6494.

[Tyriar]

I commented on the issue