Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse color mode does not work correctly with light themes #30024

Closed
wavebeem opened this issue Jul 3, 2017 · 4 comments
Closed

Reverse color mode does not work correctly with light themes #30024

wavebeem opened this issue Jul 3, 2017 · 4 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
October 2017

Comments

@wavebeem
Copy link

wavebeem commented Jul 3, 2017

  • VSCode Version: Code 1.13.1 (379d2ef, 2017-06-14T18:13:05.928Z)
  • OS Version: Darwin x64 16.6.0
  • Extensions:
Extension Author Version
vsc-material-theme Equinusocio 1.0.0
vscode-simple-icons LaurentTreguier 1.4.0
fish TeddyDD 0.0.4
vscode-eslint dbaeumer 1.2.11
python donjayamanne 0.6.7
vscode-icon-theme jtlowe 1.5.0
PowerShell ms-vscode 1.4.1
sublime-keybindings ms-vscode 2.9.0
Ruby rebornix 0.12.1
trailing-spaces shardulm94 0.2.11
theme-unoduetre wavebeem 1.4.0

Steps to Reproduce:

  1. Select a light theme
  2. Open integrated terminal
  3. Run tput rev; echo reverse video mode
  4. Observe that the output is black on white, instead of having the colors actually reversed

Screenshots:

Theme: Uno Due Tre

image

Theme: Dark+

image

NOT VSCODE: iTerm for comparison

image
@vscodebot vscodebot bot added the workbench label Jul 3, 2017
@bpasero bpasero assigned Tyriar and unassigned bpasero Jul 3, 2017
@Tyriar Tyriar mentioned this issue Jul 5, 2017
Closed
@Tyriar
Copy link
Member

Tyriar commented Jul 5, 2017

Nice find, created the upstream issue 😃

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed workbench labels Jul 5, 2017
@Tyriar Tyriar added this to the Backlog milestone Jul 5, 2017
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Jul 7, 2017
@Tyriar
Copy link
Member

Tyriar commented Oct 20, 2017

This was fixed in v1.17

screen shot 2017-10-20 at 3 43 43 pm

@Tyriar Tyriar closed this as completed Oct 20, 2017
@Tyriar
Copy link
Member

Tyriar commented Oct 20, 2017

Assigning to October for verification.

@Tyriar Tyriar modified the milestones: Backlog, October 2017 Oct 20, 2017
@wavebeem
Copy link
Author

Thank you!!

@mjbvz mjbvz added the verified Verification succeeded label Nov 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
October 2017
Development

No branches or pull requests
4 participants
@wavebeem @bpasero @Tyriar @mjbvz