Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make addon peer dependencies friendly with npm #5135

Closed
Tyriar opened this issue Aug 21, 2024 · 2 comments · Fixed by #5143
Closed

Make addon peer dependencies friendly with npm #5135

Tyriar opened this issue Aug 21, 2024 · 2 comments · Fixed by #5143
Assignees
Labels
type/debt Technical debt that could slow us down in the long run
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 21, 2024

Right now we have stable xterm.js declared as a peer dependency of the beta addons. This ends up causing issue with npm microsoft/vscode#196795 (comment). To fix this we probably need to update the peer dependency when we update the version of the addons on publish

@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Aug 21, 2024
@Tyriar Tyriar added this to the 6.0.0 milestone Aug 21, 2024
@Tyriar Tyriar self-assigned this Aug 21, 2024
@jerch
Copy link
Member

jerch commented Aug 21, 2024

Glad to see a move back to npm - it is not only the official package installer, it also got much better lately, but more importantly we encountered issues with yarn in other projects, where its package cache might apply the wrong package version (and we had to switch back to npm, mind you - those issues are all around ESM support in various 3rd party packages, grrr).

@Tyriar
Copy link
Member Author

Tyriar commented Aug 22, 2024

npm has been plenty fast for a long time and I think we also switched before package-lock.json was a thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants