Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a selection event #1093

Closed
Tyriar opened this issue Oct 28, 2017 · 0 comments
Closed

Expose a selection event #1093

Tyriar opened this issue Oct 28, 2017 · 0 comments
Labels
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 28, 2017

In order to support features like copy on select an event needs to be exposed which is fired whenever there is a new selection finalized (on mouse up). There is currently a newselection event to support middle click on Linux but this probably needs to be separate.

It's probably best not to pass the selection text with the event but instead allow consumers to call selectionText. This will save the text being calculated when it's not used.

For those interested in doing a PR checkout https://github.com/sourcelair/xterm.js/blob/v3/src/SelectionManager.ts

bmf-ribeiro added a commit to bmf-ribeiro/xterm.js that referenced this issue Nov 6, 2017
@Tyriar Tyriar closed this as completed in 923bb05 Nov 7, 2017
@Tyriar Tyriar added this to the 3.0.0 milestone Nov 7, 2017
@Tyriar Tyriar added type/enhancement Features or improvements to existing features and removed type/feature labels Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant