-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Add function to dynamically retrieve executable path #172
Conversation
763ea16
to
04d29ba
Compare
04d29ba
to
2443ea7
Compare
We could also depend on |
Thanks. I did not know this library. Although their implementation looks a bit complicated and not very "modern C++". |
It's because it's C :) at least that part, they have C++ wrappers. We could ship it on conda ... |
You don't think it is a bit overkill to wrap a single system call? |
I think it's a fine idea because then you can use the same implementation from C and C++. And it doesn't really make that much of a difference if you are calling a bunch of C functions anyways. |
I'm more concerned by the fact that the library has not been updated for 9 months and the last release was last year. |
If path functionality be added to xtl, I'd like to advocate for adding (part of) the functionality of Python's Though xtl might not be the right platform for this |
I mean, that cpplocate library has like about 10 functions, how many releases should we expect? It doesn't have the same feature bloat as the xtl, hehe. cpppath looks nice (btw @tdegeus did you ever see pystring14? |
@wolfv pystring14 looks also really nice. Seems that once more we are on similar tracks ;) Do you use Python headers/libraries, or is it stand-alone? |
Nope it's completely standalone, pure C++ :) it's a modernized version of
pystring.
Maybe we could make an organization for these kind of pythonized cpp
libraries?
…On Mon 18 Nov 2019 at 12:28, Tom de Geus ***@***.***> wrote:
@wolfv <https://github.com/wolfv> pystring14 looks also really nice.
Seems that once more we are on similar tracks ;) Do you use Python
headers/libraries, or is it stand-alone?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#172?email_source=notifications&email_token=AAGYCPQXHNTMQFZKC74L2Y3QUJ36BA5CNFSM4JOJOLL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEKECZQ#issuecomment-554975590>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGYCPUEUCZQNPAGDGHC7XLQUJ36BANCNFSM4JOJOLLQ>
.
|
Yes, that be awesome! We could add |
It's not about the number of releases, but the frequency regarding the commits. There have been some fixes in the master branch after the last release. The fact that they have not been released and the library has not been updated for a while makes me wonder if the library is still maintained and if so, how long we should wait to get a potential fix merged and released. |
Closing for now as I make it private API to xeus-python. I may contribute it again when this has been bullet-prooved by xeus-python & xeus-cling. |
Actually we have this function in mamba as well: https://github.com/TheSnakePit/mamba/blob/ff0935f0811b526c20c96866f565e5c0ff40c321/include/shell_init.hpp#L142 |
This is a utilitary function that returns the executable path in a cross-platform fashion.