Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Add function to dynamically retrieve executable path #172

Closed
wants to merge 1 commit into from

Conversation

SylvainCorlay
Copy link
Member

@SylvainCorlay SylvainCorlay commented Nov 17, 2019

This is a utilitary function that returns the executable path in a cross-platform fashion.

@SylvainCorlay SylvainCorlay force-pushed the xprefix branch 4 times, most recently from 763ea16 to 04d29ba Compare November 17, 2019 16:35
@wolfv
Copy link
Member

wolfv commented Nov 17, 2019

We could also depend on cpplocate? Might be better to offload this to a thirdparty lib? https://github.com/cginternals/cpplocate/blob/master/source/liblocate/source/liblocate.c

@SylvainCorlay
Copy link
Member Author

Thanks. I did not know this library.

Although their implementation looks a bit complicated and not very "modern C++".

@wolfv
Copy link
Member

wolfv commented Nov 17, 2019

It's because it's C :) at least that part, they have C++ wrappers. We could ship it on conda ...

@SylvainCorlay
Copy link
Member Author

It's because it's C :) at least that part, they have C++ wrappers. We could ship it on conda ...

You don't think it is a bit overkill to wrap a single system call?

@wolfv
Copy link
Member

wolfv commented Nov 17, 2019

I think it's a fine idea because then you can use the same implementation from C and C++. And it doesn't really make that much of a difference if you are calling a bunch of C functions anyways.

@JohanMabille
Copy link
Member

I'm more concerned by the fact that the library has not been updated for 9 months and the last release was last year.

@tdegeus
Copy link
Member

tdegeus commented Nov 18, 2019

If path functionality be added to xtl, I'd like to advocate for adding (part of) the functionality of Python's os.path. I've always missed some simple header only functions (i.e. not boost); e.g. https://github.com/tdegeus/cpppath

Though xtl might not be the right platform for this

@wolfv
Copy link
Member

wolfv commented Nov 18, 2019

I mean, that cpplocate library has like about 10 functions, how many releases should we expect? It doesn't have the same feature bloat as the xtl, hehe.

cpppath looks nice (btw @tdegeus did you ever see pystring14?

@tdegeus
Copy link
Member

tdegeus commented Nov 18, 2019

@wolfv pystring14 looks also really nice. Seems that once more we are on similar tracks ;) Do you use Python headers/libraries, or is it stand-alone?

@wolfv
Copy link
Member

wolfv commented Nov 18, 2019 via email

@tdegeus
Copy link
Member

tdegeus commented Nov 18, 2019

Yes, that be awesome! We could add cppcolormap too?

@JohanMabille
Copy link
Member

I mean, that cpplocate library has like about 10 functions, how many releases should we expect?

It's not about the number of releases, but the frequency regarding the commits. xtl does not have that much activiy, however we try to release quickly when we fix issues.

There have been some fixes in the master branch after the last release. The fact that they have not been released and the library has not been updated for a while makes me wonder if the library is still maintained and if so, how long we should wait to get a potential fix merged and released.

@SylvainCorlay
Copy link
Member Author

Closing for now as I make it private API to xeus-python.

I may contribute it again when this has been bullet-prooved by xeus-python & xeus-cling.

@wolfv
Copy link
Member

wolfv commented Aug 6, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants