boostrap: no need to install tortoiseorm instrumentation if pydantic …

…is found Not every user of pydantic is using tortoise orm so checking for tortoise orm should be enough.
xrmx · Apr 11, 2024 · d0f7e7a · d0f7e7a
1 parent 804a909
commit d0f7e7a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,9 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## Unreleased
+
 - `opentelemetry-sdk-extension-aws` Register AWS resource detectors under the
   `opentelemetry_resource_detector` entry point
   ([#2382](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2382))
+- `opentelemetry-instrumentation` On bootstrap don't install tortoise orm instrumentation if pydantic is found
+  ([#2409](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2409))
 
 ### Breaking changes
 

diff --git a/instrumentation/opentelemetry-instrumentation-tortoiseorm/pyproject.toml b/instrumentation/opentelemetry-instrumentation-tortoiseorm/pyproject.toml
@@ -32,7 +32,6 @@ dependencies = [
 [project.optional-dependencies]
 instruments = [
   "tortoise-orm >= 0.17.0",
-  "pydantic >= 1.10.2"
 ]
 
 [project.entry-points.opentelemetry_instrumentor]

diff --git a/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py b/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py
@@ -176,10 +176,6 @@
         "library": "tortoise-orm >= 0.17.0",
         "instrumentation": "opentelemetry-instrumentation-tortoiseorm==0.46b0.dev",
     },
-    {
-        "library": "pydantic >= 1.10.2",
-        "instrumentation": "opentelemetry-instrumentation-tortoiseorm==0.46b0.dev",
-    },
     {
         "library": "urllib3 >= 1.0.0, < 3.0.0",
         "instrumentation": "opentelemetry-instrumentation-urllib3==0.46b0.dev",