enhance container name validation

xray-labs · Sep 14, 2024 · 6a396c9 · 6a396c9
1 parent 0538da4
commit 6a396c9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/BlobStorage/Concerns/ValidateContainerName.php b/src/BlobStorage/Concerns/ValidateContainerName.php
@@ -13,7 +13,7 @@ protected function validateContainerName(string $name): void
     {
         $replaced = preg_replace('/[^a-z0-9-]/', '', $name);
 
-        if ($replaced !== $name) {
+        if (trim($name) === '' || $replaced !== $name) {
             throw InvalidArgumentException::create("Invalid container name: {$name}");
         }
     }

diff --git a/tests/Feature/BlobStorage/Concerns/ValidateContainerNameTest.php b/tests/Feature/BlobStorage/Concerns/ValidateContainerNameTest.php
@@ -37,4 +37,5 @@ public function assertContainerName(string $name): void
     'With Capital Letters' => ['TEST'],
     'With Spaces'          => ['test test'],
     'With Special Chars'   => ['test*'],
+    'Empty String'         => [''],
 ]);