This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
This change was a simple refactor. It was necessary because if a user going through this demo did not not have a PayID associated with both the XRPL and BTC networks the demo would result in a fatal error. This refactor allows users to demo the PayID resolve according to the networks for which their PayID is associated.
Type of Change
Before / After
Before the refactor there was one file for each of the PayID demos according to their respective language NodeJS, Java, and Swift. After there is three files for each PayID demo according to their respective languages.
Test Plan
Using VS Code I was able to test the NodeJS refactored demos and Java (Maven) refactored demos which both resulted in expected output. I've been unable to test the refactored Swift demos thus they will need more attention.