Skip to content

Commit

Permalink
Release v0.21.0 for beta 5 (FuelLabs#1513)
Browse files Browse the repository at this point in the history
## Version 0.21.0

This release focuses on preparing `fuel-core` for the mainnet
environment.
- Most of the changes improved the security and stability of the node.
- The gas model was reworked to cover all aspects of execution.
- The benchmarking system was significantly enhanced, covering worst
scenarios.
- A new set of benchmarks was added to track the accuracy of gas prices.
- Optimized heavy operations and removed/replaced exploitable
functionality.

Besides that, there are more concrete changes:
- Unified naming conventions for all CLI arguments. Added dependencies
between related fields to avoid misconfiguration in case of missing
arguments. Added `--debug` flag that enables additional functionality
like a debugger.
- Improved telemetry to cover the internal work of services and added
support for the Pyroscope, allowing it to generate real-time flamegraphs
to track performance.
- Improved stability of the P2P layer and adjusted the updating of
reputation. The speed of block synchronization was significantly
increased.
- The node is more stable and resilient. Improved DoS resistance and
resource management. Fixed critical bugs during state transition.
- Reworked the `Mint` transaction to accumulate the fee from block
production inside the contract defined by the block producer.

FuelVM received a lot of safety and stability improvements:
- The audit helped identify some bugs and errors that have been
successfully fixed.
- Updated the gas price model to charge for resources used during the
transaction lifecycle.
- Added `no_std` and 32 bit system support. This opens doors for fraud
proving in the future.
- Removed the `ChainId` from the `PredicateId` calculation, allowing the
use of predicates cross-chain.
- Improvements in the performance of some storage-related opcodes.
- Support the `ECAL` instruction that allows adding custom functionality
to the VM. It can be used to create unique rollups or advanced indexers
in the future.
- Support of [transaction
policies](https://github.com/FuelLabs/fuel-vm/blob/master/CHANGELOG.md#version-0420)
provides additional safety for the user.
It also allows the implementation of a multi-dimensional price model in
the future, making the transaction execution cheaper and allowing more
transactions that don't affect storage.
- Refactored errors, returning more detailed errors to the user,
simplifying debugging.

### Added

- [FuelLabs#1503](FuelLabs#1503): Add `gtf`
opcode sanity check.
- [FuelLabs#1502](FuelLabs#1502): Added price
benchmark for `vm_initialization`.
- [FuelLabs#1501](FuelLabs#1501): Add a CLI
command for generating a fee collection contract.
- [FuelLabs#1492](FuelLabs#1492): Support
backward iteration in the RocksDB. It allows backward queries that were
not allowed before.
- [FuelLabs#1490](FuelLabs#1490): Add push and
pop benchmarks.
- [FuelLabs#1485](FuelLabs#1485): Prepare rc
release of fuel core v0.21
- [FuelLabs#1476](FuelLabs#1453): Add the
majority of the "other" benchmarks for contract opcodes.
- [FuelLabs#1473](FuelLabs#1473): Expose
fuel-core version as a constant
- [FuelLabs#1469](FuelLabs#1469): Added
support of bloom filter for RocksDB tables and increased the block
cache.
- [FuelLabs#1465](FuelLabs#1465): Improvements
for keygen cli and crates
- [FuelLabs#1642](FuelLabs#1462): Added
benchmark to measure the performance of contract state and contract ID
calculation; use for gas costing.
- [FuelLabs#1457](FuelLabs#1457): Fixing
incorrect measurement for fast(µs) opcodes.
- [FuelLabs#1456](FuelLabs#1456): Added
flushing of the RocksDB during a graceful shutdown.
- [FuelLabs#1456](FuelLabs#1456): Added more
logs to track the service lifecycle.
- [FuelLabs#1453](FuelLabs#1453): Add the
majority of the "sanity" benchmarks for contract opcodes.
- [FuelLabs#1452](FuelLabs#1452): Added
benchmark to measure the performance of contract root calculation when
utilizing the maximum contract size; used for gas costing of contract
root during predicate owner validation.
- [FuelLabs#1449](FuelLabs#1449): Fix coin
pagination in e2e test client.
- [FuelLabs#1447](FuelLabs#1447): Add timeout
for continuous e2e tests
- [FuelLabs#1444](FuelLabs#1444): Add "sanity"
benchmarks for memory opcodes.
- [FuelLabs#1437](FuelLabs#1437): Add some
transaction throughput tests for basic transfers.
- [FuelLabs#1436](FuelLabs#1436): Add a github
action to continuously test beta-4.
- [FuelLabs#1433](FuelLabs#1433): Add "sanity"
benchmarks for flow opcodes.
- [FuelLabs#1432](FuelLabs#1432): Add a new
`--api-request-timeout` argument to control TTL for GraphQL requests.
- [FuelLabs#1430](FuelLabs#1430): Add "sanity"
benchmarks for crypto opcodes.
- [FuelLabs#1426](FuelLabs#1426) Split keygen
into a create and a binary.
- [FuelLabs#1419](FuelLabs#1419): Add
additional "sanity" benchmarks for arithmetic op code instructions.
- [FuelLabs#1411](FuelLabs#1411): Added WASM
and `no_std` compatibility.
- [FuelLabs#1405](FuelLabs#1405): Use correct
names for service metrics.
- [FuelLabs#1400](FuelLabs#1400): Add releasy
beta to fuel-core so that new commits to fuel-core master triggers
fuels-rs.
- [FuelLabs#1371](FuelLabs#1371): Add new
client function for querying the `MessageStatus` for a specific message
(by `Nonce`).
- [FuelLabs#1356](FuelLabs#1356): Add peer
reputation reporting to heartbeat code.
- [FuelLabs#1355](FuelLabs#1355): Added new
metrics related to block importing, such as tps, sync delays etc.
- [FuelLabs#1339](FuelLabs#1339): Adds
`baseAssetId` to `FeeParameters` in the GraphQL API.
- [FuelLabs#1331](FuelLabs#1331): Add peer
reputation reporting to block import code.
- [FuelLabs#1324](FuelLabs#1324): Added
pyroscope profiling to fuel-core, intended to be used by a secondary
docker image that has debug symbols enabled.
- [FuelLabs#1309](FuelLabs#1309): Add
documentation for running debug builds with CLion and Visual Studio
Code.
- [FuelLabs#1308](FuelLabs#1308): Add support
for loading .env files when compiling with the `env` feature. This
allows users to conveniently supply CLI arguments in a secure and
IDE-agnostic way.
- [FuelLabs#1304](FuelLabs#1304): Implemented
`submit_and_await_commit_with_receipts` method for `FuelClient`.
- [FuelLabs#1286](FuelLabs#1286): Include
readable names for test cases where missing.
- [FuelLabs#1274](FuelLabs#1274): Added tests
to benchmark block synchronization.
- [FuelLabs#1263](FuelLabs#1263): Add gas
benchmarks for `ED19` and `ECR1` instructions.

### Changed

- [FuelLabs#1512](FuelLabs#1512): Internally
simplify merkle_contract_state_range.
- [FuelLabs#1507](FuelLabs#1507): Updated
chain configuration to be ready for beta 5 network. It includes opcode
prices from the latest benchmark and contract for the block producer.
- [FuelLabs#1477](FuelLabs#1477): Upgraded the
Rust version used in CI and containers to 1.73.0. Also includes
associated Clippy changes.
- [FuelLabs#1469](FuelLabs#1469): Replaced
usage of `MemoryTransactionView` by `Checkpoint` database in the
benchmarks.
- [FuelLabs#1468](FuelLabs#1468): Bumped
version of the `fuel-vm` to `v0.40.0`. It brings some breaking changes
into consensus parameters API because of changes in the underlying
types.
- [FuelLabs#1466](FuelLabs#1466): Handling
overflows during arithmetic operations.
- [FuelLabs#1460](FuelLabs#1460): Change
tracking branch from main to master for releasy tests.
- [FuelLabs#1454](FuelLabs#1454): Update gas
benchmarks for opcodes that append receipts.
- [FuelLabs#1440](FuelLabs#1440): Don't report
reserved nodes that send invalid transactions.
- [FuelLabs#1439](FuelLabs#1439): Reduced
memory BMT consumption during creation of the header.
- [FuelLabs#1434](FuelLabs#1434): Continue
gossiping transactions to reserved peers regardless of gossiping
reputation score.
- [FuelLabs#1408](FuelLabs#1408): Update gas
benchmarks for storage opcodes to use a pre-populated database to get
more accurate worst-case costs.
- [FuelLabs#1399](FuelLabs#1399): The Relayer
now queries Ethereum for its latest finalized block instead of using a
configurable "finalization period" to presume finality.
- [FuelLabs#1397](FuelLabs#1397): Improved
keygen. Created a crate to be included from forc plugins and upgraded
internal library to drop requirement of protoc to build
- [FuelLabs#1395](FuelLabs#1395): Add
DependentCost benchmarks for `k256`, `s256` and `mcpi` instructions.
- [FuelLabs#1393](FuelLabs#1393): Increase
heartbeat timeout from `2` to `60` seconds, as suggested in [this
issue](FuelLabs#1330).
- [FuelLabs#1392](FuelLabs#1392): Fixed an
overflow in `message_proof`.
- [FuelLabs#1390](FuelLabs#1390): Up the
`ethers` version to `2` to fix an issue with `tungstenite`.
- [FuelLabs#1383](FuelLabs#1383): Disallow
usage of `log` crate internally in favor of `tracing` crate.
- [FuelLabs#1380](FuelLabs#1380): Add
preliminary, hard-coded config values for heartbeat peer reputation,
removing `todo`.
- [FuelLabs#1377](FuelLabs#1377): Remove
`DiscoveryEvent` and use `KademliaEvent` directly in
`DiscoveryBehavior`.
- [FuelLabs#1366](FuelLabs#1366): Improve
caching during docker builds in CI by replacing gha
- [FuelLabs#1358](FuelLabs#1358): Upgraded the
Rust version used in CI to 1.72.0. Also includes associated Clippy
changes.
- [FuelLabs#1349](FuelLabs#1349): Updated
peer-to-peer transactions API to support multiple blocks in a single
request, and updated block synchronization to request multiple blocks
based on the configured range of headers.
- [FuelLabs#1342](FuelLabs#1342): Add error
handling for P2P requests to return `None` to requester and log error.
- [FuelLabs#1318](FuelLabs#1318): Modified
block synchronization to use asynchronous task execution when retrieving
block headers.
- [FuelLabs#1314](FuelLabs#1314): Removed
`types::ConsensusParameters` in favour of `fuel_tx:ConsensusParameters`.
- [FuelLabs#1302](FuelLabs#1302): Removed the
usage of flake and building of the bridge contract ABI.
It simplifies the maintenance and updating of the events, requiring only
putting the event definition into the codebase of the relayer.
- [FuelLabs#1293](FuelLabs#1293):
Parallelized the `estimate_predicates` endpoint to utilize all available
threads.
- [FuelLabs#1270](FuelLabs#1270): Modify the
way block headers are retrieved from peers to be done in batches.

#### Breaking
- [FuelLabs#1506](FuelLabs#1506): Added
validation of the coin's fields during block production and validation.
Before, it was possible to submit a transaction that didn't match the
coin's values in the database, allowing printing/using unavailable
assets.
- [FuelLabs#1491](FuelLabs#1491): Removed
unused request and response variants from the Gossipsub implementation,
as well as related definitions and tests. Specifically, this removes
gossiping of `ConsensusVote` and `NewBlock` events.
- [FuelLabs#1472](FuelLabs#1472): Upgraded
`fuel-vm` to `v0.42.0`. It introduces transaction policies that changes
layout of the transaction. FOr more information check the
[v0.42.0](FuelLabs/fuel-vm#635) release.
- [FuelLabs#1470](FuelLabs#1470): Divide
`DependentCost` into "light" and "heavy" operations.
- [FuelLabs#1464](FuelLabs#1464): Avoid
possible truncation of higher bits. It may invalidate the code that
truncated higher bits causing different behavior on 32-bit vs. 64-bit
systems. The change affects some endpoints that now require lesser
integers.
- [FuelLabs#1432](FuelLabs#1432): All
subscriptions and requests have a TTL now. So each subscription
lifecycle is limited in time. If the subscription is closed because of
TTL, it means that you subscribed after your transaction had been
dropped by the network.
- [FuelLabs#1407](FuelLabs#1407): The
recipient is a `ContractId` instead of `Address`. The block producer
should deploy its contract to receive the transaction fee. The collected
fee is zero until the recipient contract is set.
- [FuelLabs#1407](FuelLabs#1407): The `Mint`
transaction is reworked with new fields to support the account-base
model. It affects serialization and deserialization of the transaction
and also affects GraphQL schema.
- [FuelLabs#1407](FuelLabs#1407): The `Mint`
transaction is the last transaction in the block instead of the first.
- [FuelLabs#1374](FuelLabs#1374): Renamed
`base_chain_height` to `da_height` and return current relayer height
instead of latest Fuel block height.
- [FuelLabs#1367](FuelLabs#1367): Update to
the latest version of fuel-vm.
- [FuelLabs#1363](FuelLabs#1363): Change
message_proof api to take `nonce` instead of `message_id`
- [FuelLabs#1355](FuelLabs#1355): Removed the
`metrics` feature flag from the fuel-core crate, and metrics are now
included by default.
- [FuelLabs#1339](FuelLabs#1339): Added a new
required field called `base_asset_id` to the `FeeParameters` definition
in `ConsensusParameters`, as well as default values for `base_asset_id`
in the `beta` and `dev` chain specifications.
- [FuelLabs#1322](FuelLabs#1322):
The `debug` flag is added to the CLI. The flag should be used for local
development only. Enabling debug mode:
      - Allows GraphQL Endpoints to arbitrarily advance blocks.
      - Enables debugger GraphQL Endpoints.
      - Allows setting `utxo_validation` to `false`.
- [FuelLabs#1318](FuelLabs#1318): Removed the
`--sync-max-header-batch-requests` CLI argument, and renamed
`--sync-max-get-txns` to `--sync-block-stream-buffer-size` to better
represent the current behavior in the import.
- [FuelLabs#1290](FuelLabs#1290): Standardize
CLI args to use `-` instead of `_`.
- [FuelLabs#1279](FuelLabs#1279): Added a new
CLI flag to enable the Relayer service `--enable-relayer`, and disabled
the Relayer service by default. When supplying the `--enable-relayer`
flag, the `--relayer` argument becomes mandatory, and omitting it is an
error. Similarly, providing a `--relayer` argument without the
`--enable-relayer` flag is an error. Lastly, providing the `--keypair`
or `--network` arguments will also produce an error if the
`--enable-p2p` flag is not set.
- [FuelLabs#1262](FuelLabs#1262): The
`ConsensusParameters` aggregates all configuration data related to the
consensus. It contains many fields that are segregated by the usage. The
API of some functions was affected to use lesser types instead the whole
`ConsensusParameters`. It is a huge breaking change requiring
repetitively monotonically updating all places that use the
`ConsensusParameters`. But during updating, consider that maybe you can
use lesser types. Usage of them may simplify signatures of methods and
make them more user-friendly and transparent.

### Removed

#### Breaking
- [FuelLabs#1484](FuelLabs#1484): Removed
`--network` CLI argument. Now the name of the network is fetched form
chain configuration.
- [FuelLabs#1399](FuelLabs#1399): Removed
`relayer-da-finalization` parameter from the relayer CLI.
- [FuelLabs#1338](FuelLabs#1338): Updated
GraphQL client to use `DependentCost` for `k256`, `mcpi`, `s256`,
`scwq`, `swwq` opcodes.
- [FuelLabs#1322](FuelLabs#1322): The
`manual_blocks_enabled` flag is removed from the CLI. The analog is a
`debug` flag.

## What's Changed
* Added changelog in the same way as we did for `fuel-vm` by @xgreenx in
FuelLabs#1287
* Decompose consensus params struct by @MitchTurner in
FuelLabs#1262
* Replace all instances of `_` in CLI `long` arguments with `-` by
@MitchTurner in FuelLabs#1290
* [rpc] Parallelise estimate_predicates endpoint by @YusongWang in
FuelLabs#1293
* Add readable test names to test cases by @MitchTurner in
FuelLabs#1286
* ED19 and ECR1 benchmarks by @Dentosal in
FuelLabs#1263
* feat: Add `enable-relayer` flag to `fuel-core` CLI by @bvrooman in
FuelLabs#1279
* Small nits found during deploying and benchmarking by @xgreenx in
FuelLabs#1303
* Implemented `submit_and_await_commit_with_receipts` method by @xgreenx
in FuelLabs#1304
* Removed the usage of flake and building of the bridge contract ABI by
@xgreenx in FuelLabs#1302
* Download range of headers during syncing by @MitchTurner in
FuelLabs#1270
* feat: Enable .env file loading using `env` feature by @bvrooman in
FuelLabs#1308
* chore: Remove types::ConsensusParameters by @bvrooman in
FuelLabs#1314
* docs: Debugging instructions using IDEs by @bvrooman in
FuelLabs#1309
* test: Block Import benchmarks and test helpers by @bvrooman in
FuelLabs#1274
* Fix audit CI for `webpki` by @xgreenx in
FuelLabs#1319
* chore: Single buffer block sync by @bvrooman in
FuelLabs#1318
* Run unit tests without default features only for specific crates by
@xgreenx in FuelLabs#1321
* Added support for `debug` CLI flag. by @xgreenx in
FuelLabs#1322
* Report Peers that give bad Block Info by @MitchTurner in
FuelLabs#1331
* Pyroscope profiling by @Voxelot in
FuelLabs#1324
* Add error handling for P2P requests to return `None` to requester and
log error by @MitchTurner in
FuelLabs#1342
* Importer Metrics by @Voxelot in
FuelLabs#1355
* chore: Upgrade to Rust 1.72.0 in CI by @bvrooman in
FuelLabs#1358
* chore: Upgrade `fuel-vm` to 0.37.0 by @bvrooman in
FuelLabs#1338
* docs: remove stale schema by @calldelegation in
FuelLabs#1362
* Replace message_id with nonce in `MessageProof` query by @MitchTurner
in FuelLabs#1363
* feat: Configurable base asset by @bvrooman in
FuelLabs#1339
* avoid gha caching for docker builds by @Voxelot in
FuelLabs#1366
* Add tracking for peer heartbeats by @MitchTurner in
FuelLabs#1356
* docs: fix broken link in README by @PaulRBerg in
FuelLabs#1357
* Use right level of error for `.env` file and duplicated service by
@xgreenx in FuelLabs#1372
* Add query and handling for `MessageStatus` by @MitchTurner in
FuelLabs#1371
* Renamed `base_chain_height` to `da_height` and return current relayer
height instead of latest Fuel block height by @xgreenx in
FuelLabs#1374
* Remove `DiscoveryEvent` and use `KademliaEvent` instead by
@MitchTurner in FuelLabs#1377
* Remove todo from code and provide some preliminary peer review config
values by @MitchTurner in
FuelLabs#1380
* Clippy lint to disallow logging crate macros in favor of tracing by
@Dentosal in FuelLabs#1383
* fuel-vm nostd update by @Dentosal in
FuelLabs#1367
* Up the `ethers` version to `2` to fix an issue with `tungstenite` by
@xgreenx in FuelLabs#1390
* Increase heartbeat timeout to one minute by @Dentosal in
FuelLabs#1393
* feat: batch transactions import by @bvrooman in
FuelLabs#1349
* Fix an interger overflow in message_proof when looking beyond genesis
by @Dentosal in FuelLabs#1392
* Improve keygen by @cr-fuel in
FuelLabs#1397
* Benchmark {k256, s256, mcpi} opcodes using DependentCost by @Dentosal
in FuelLabs#1395
* Use correct names for service metrics by @xgreenx in
FuelLabs#1405
* feat: Retrieve finalized blocks from Ethereum by @bvrooman in
FuelLabs#1399
* Updated CI to run `cargo update` weekly by @xgreenx in
FuelLabs#1415
* CI `cargo update` weekly by @xgreenx in
FuelLabs#1416
* Weekly `cargo update` by @github-actions in
FuelLabs#1417
* Fix typos by @GoodDaisy in
FuelLabs#1424
* feat: Support no_std and WASM compilation for `fuel-core` crates by
@bvrooman in FuelLabs#1411
* Create sanity benchmark checks for all the arithmetic op codes by
@MitchTurner in FuelLabs#1419
* Update benchmarking and collecting for `scwq`, `swwq` and `srwq`
opcodes by @xgreenx in FuelLabs#1427
* Account-base fee collection by @xgreenx in
FuelLabs#1407
* Rollback modification of the chain specification by @xgreenx in
FuelLabs#1429
* Tx subscription cleanup (FuelLabs#1422) by @xgreenx in
FuelLabs#1432
* Mark reserved peers as explicit for gossipsub to avoid reputation
decreasing (FuelLabs#1423) by @xgreenx in
FuelLabs#1434
* Weekly `cargo update` by @github-actions in
FuelLabs#1438
* ci: add beta releasy to fuel-core by @kayagokalp in
FuelLabs#1400
* setup a cron job to test beta-4 continuously by @Voxelot in
FuelLabs#1436
* chore: Use MerkleRootCalculator when only BMT root is needed by
@bvrooman in FuelLabs#1439
* Crypto op code sanity checks by @MitchTurner in
FuelLabs#1430
* Update gas benchmarks for some storage opcodes by @Dentosal in
FuelLabs#1408
* Split keygen into a create and a binary by @cr-fuel in
FuelLabs#1426
* Basic Transfer TPS Benchmarking by @Voxelot in
FuelLabs#1437
* "flow" op code sanity benchmarks by @MitchTurner in
FuelLabs#1433
* Applying `FuelLabs#1435` to `master` by @xgreenx in
FuelLabs#1440
* "memory" opcode sanity checks by @MitchTurner in
FuelLabs#1444
* Add timeout to E2E test by @Voxelot in
FuelLabs#1447
* fix owns_coins to properly paginate by @Voxelot in
FuelLabs#1449
* Fixing incorrect measurement for fast(µs) opcodes by @xgreenx in
FuelLabs#1457
* Call `flush` during end of the `FuelService` by @xgreenx in
FuelLabs#1456
* chore: fix releasy test tracking branch from `main` to `master` by
@kayagokalp in FuelLabs#1460
* Weekly `cargo update` by @github-actions in
FuelLabs#1461
* `DB::repair` breaks the table for checkpoints by @xgreenx in
FuelLabs#1463
* Avoid possible truncation of higher bits by @xgreenx in
FuelLabs#1464
* Bumping `fuel-vm` to `v0.40.0` by @xgreenx in
FuelLabs#1468
* Improvements for keygen cli and crates by @cr-fuel in
FuelLabs#1465
* Handling overflows during arithmetic operations by @xgreenx in
FuelLabs#1466
* test: Add contract code root benchmark by @bvrooman in
FuelLabs#1452
* test: Add state root and contract id benchmarks by @bvrooman in
FuelLabs#1462
* Avoid storage caching in benchmarks by @xgreenx in
FuelLabs#1469
* Weekly `cargo update` by @github-actions in
FuelLabs#1471
* Expose fuel-core version as a constant by @Br1ght0ne in
FuelLabs#1473
* Upgrade ed25519_dalek 1.0.1 -> 2.0.0 by @Dentosal in
FuelLabs#1475
* chore: Upgrade Rust 1.73 by @bvrooman in
FuelLabs#1477
* Decrease number of iterations for sequential benchmarks by @xgreenx in
FuelLabs#1480
* Add mldv bench by @Dentosal in
FuelLabs#1481
* feat: Separate light and heavy gas costs (core) by @bvrooman in
FuelLabs#1483
* chore: Remove `network` parameter from CLI by @bvrooman in
FuelLabs#1484
* Transaction policies support by @xgreenx in
FuelLabs#1472
* stage release candidate for beta-5 by @Voxelot in
FuelLabs#1485
* setup docker auth for binary publishing by @Voxelot in
FuelLabs#1488
* Fix macos binary publishing by @xgreenx in
FuelLabs#1489
* Add documentation for our calculation of a _reasonable_ gas fee for
storage by @MitchTurner in
FuelLabs#1478
* "contract" op code sanity checks by @MitchTurner in
FuelLabs#1453
* "other" op code sanity check by @MitchTurner in
FuelLabs#1476
* Add push and pop benches by @MitchTurner in
FuelLabs#1490
* chore: Remove unused gossipsub items by @bvrooman in
FuelLabs#1491
* Adjusting of the prices benchmarks after sanity check benchmarks by
@xgreenx in FuelLabs#1494
* Weekly `cargo update` by @github-actions in
FuelLabs#1498
* Update benches that are affected by receipts by @Dentosal in
FuelLabs#1454
* Support backward iteration in the RocksDB by @xgreenx in
FuelLabs#1492
* Added validation of the coin's fields during block production and
validation by @xgreenx in
FuelLabs#1506
* Added price benchmark for `vm_initialization` by @xgreenx in
FuelLabs#1502
* Sanity-check `gtf` opcode by @MitchTurner in
FuelLabs#1503
* Tool for generating fee collection contract by @Voxelot in
FuelLabs#1501
* Chain config for beta 5 network by @xgreenx in
FuelLabs#1507
* Remove usage of iter_all_filtered from merkle_contract_state_range by
@Dentosal in FuelLabs#1512

## New Contributors
* @YusongWang made their first contribution in
FuelLabs#1293
* @calldelegation made their first contribution in
FuelLabs#1362
* @PaulRBerg made their first contribution in
FuelLabs#1357
* @cr-fuel made their first contribution in
FuelLabs#1397
* @github-actions made their first contribution in
FuelLabs#1417
* @GoodDaisy made their first contribution in
FuelLabs#1424

**Full Changelog**:
FuelLabs/fuel-core@v0.20.8...v0.21.0

---------

Co-authored-by: Brandon Vrooman <[email protected]>
  • Loading branch information
xgreenx and Brandon Vrooman authored Nov 24, 2023
1 parent 87392ce commit 21cafe6
Show file tree
Hide file tree
Showing 8 changed files with 505 additions and 517 deletions.
76 changes: 51 additions & 25 deletions CHANGELOG.md

Large diffs are not rendered by default.

247 changes: 107 additions & 140 deletions Cargo.lock

Large diffs are not rendered by default.

48 changes: 24 additions & 24 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -46,33 +46,33 @@ homepage = "https://fuel.network/"
keywords = ["blockchain", "cryptocurrencies", "fuel-vm", "vm"]
license = "BUSL-1.1"
repository = "https://github.com/FuelLabs/fuel-core"
version = "0.21.0-rc.1"
version = "0.21.0"

[workspace.dependencies]
# Workspace members
fuel-core = { version = "0.21.0-rc.1", path = "./crates/fuel-core", default-features = false }
fuel-core-client-bin = { version = "0.21.0-rc.1", path = "./bin/client" }
fuel-core-bin = { version = "0.21.0-rc.1", path = "./bin/fuel-core" }
fuel-core-keygen = { version = "0.21.0-rc.1", path = "./crates/keygen" }
fuel-core-keygen-bin = { version = "0.21.0-rc.1", path = "./bin/keygen" }
fuel-core-chain-config = { version = "0.21.0-rc.1", path = "./crates/chain-config" }
fuel-core-client = { version = "0.21.0-rc.1", path = "./crates/client" }
fuel-core-database = { version = "0.21.0-rc.1", path = "./crates/database" }
fuel-core-metrics = { version = "0.21.0-rc.1", path = "./crates/metrics" }
fuel-core-services = { version = "0.21.0-rc.1", path = "./crates/services" }
fuel-core-consensus-module = { version = "0.21.0-rc.1", path = "./crates/services/consensus_module" }
fuel-core-bft = { version = "0.21.0-rc.1", path = "./crates/services/consensus_module/bft" }
fuel-core-poa = { version = "0.21.0-rc.1", path = "./crates/services/consensus_module/poa" }
fuel-core-executor = { version = "0.21.0-rc.1", path = "./crates/services/executor" }
fuel-core-importer = { version = "0.21.0-rc.1", path = "./crates/services/importer" }
fuel-core-p2p = { version = "0.21.0-rc.1", path = "./crates/services/p2p" }
fuel-core-producer = { version = "0.21.0-rc.1", path = "./crates/services/producer" }
fuel-core-relayer = { version = "0.21.0-rc.1", path = "./crates/services/relayer" }
fuel-core-sync = { version = "0.21.0-rc.1", path = "./crates/services/sync" }
fuel-core-txpool = { version = "0.21.0-rc.1", path = "./crates/services/txpool" }
fuel-core-storage = { version = "0.21.0-rc.1", path = "./crates/storage" }
fuel-core-trace = { version = "0.21.0-rc.1", path = "./crates/trace" }
fuel-core-types = { version = "0.21.0-rc.1", path = "./crates/types", default-features = false }
fuel-core = { version = "0.21.0", path = "./crates/fuel-core", default-features = false }
fuel-core-client-bin = { version = "0.21.0", path = "./bin/client" }
fuel-core-bin = { version = "0.21.0", path = "./bin/fuel-core" }
fuel-core-keygen = { version = "0.21.0", path = "./crates/keygen" }
fuel-core-keygen-bin = { version = "0.21.0", path = "./bin/keygen" }
fuel-core-chain-config = { version = "0.21.0", path = "./crates/chain-config" }
fuel-core-client = { version = "0.21.0", path = "./crates/client" }
fuel-core-database = { version = "0.21.0", path = "./crates/database" }
fuel-core-metrics = { version = "0.21.0", path = "./crates/metrics" }
fuel-core-services = { version = "0.21.0", path = "./crates/services" }
fuel-core-consensus-module = { version = "0.21.0", path = "./crates/services/consensus_module" }
fuel-core-bft = { version = "0.21.0", path = "./crates/services/consensus_module/bft" }
fuel-core-poa = { version = "0.21.0", path = "./crates/services/consensus_module/poa" }
fuel-core-executor = { version = "0.21.0", path = "./crates/services/executor" }
fuel-core-importer = { version = "0.21.0", path = "./crates/services/importer" }
fuel-core-p2p = { version = "0.21.0", path = "./crates/services/p2p" }
fuel-core-producer = { version = "0.21.0", path = "./crates/services/producer" }
fuel-core-relayer = { version = "0.21.0", path = "./crates/services/relayer" }
fuel-core-sync = { version = "0.21.0", path = "./crates/services/sync" }
fuel-core-txpool = { version = "0.21.0", path = "./crates/services/txpool" }
fuel-core-storage = { version = "0.21.0", path = "./crates/storage" }
fuel-core-trace = { version = "0.21.0", path = "./crates/trace" }
fuel-core-types = { version = "0.21.0", path = "./crates/types", default-features = false }
fuel-core-tests = { version = "0.0.0", path = "./tests" }
fuel-core-xtask = { version = "0.0.0", path = "./xtask" }

Expand Down
3 changes: 0 additions & 3 deletions crates/chain-config/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,10 @@ serde_with = "1.11"
tracing = "0.1"

[dev-dependencies]
fuel-core = { workspace = true }
fuel-core-client = { workspace = true }
fuel-core-types = { workspace = true, default-features = false, features = ["random", "serde"] }
insta = { workspace = true }
rand = { workspace = true }
serde_json = { version = "1.0", features = ["raw_value"] }
tokio = { workspace = true, features = ["full"] }

[features]
default = ["std"]
Expand Down
324 changes: 0 additions & 324 deletions crates/chain-config/src/fee_collection_contract.rs
Original file line number Diff line number Diff line change
Expand Up @@ -65,327 +65,3 @@ pub fn generate(address: Address) -> Vec<u8> {

asm_bytes
}

#[cfg(test)]
#[allow(clippy::cast_possible_truncation)]
#[allow(clippy::arithmetic_side_effects)]
mod tests {
use super::*;
use crate::SecretKey;

use rand::{
rngs::StdRng,
Rng,
SeedableRng,
};

use fuel_core::service::{
Config,
FuelService,
};
use fuel_core_client::client::{
types::TransactionStatus,
FuelClient,
};
use fuel_core_types::{
fuel_asm::GTFArgs,
fuel_tx::{
Cacheable,
Finalizable,
Input,
Output,
TransactionBuilder,
Witness,
},
fuel_types::{
canonical::Serialize,
AssetId,
BlockHeight,
ChainId,
ContractId,
Salt,
},
};

struct TestContext {
address: Address,
contract_id: ContractId,
_node: FuelService,
client: FuelClient,
}

async fn setup(rng: &mut StdRng) -> TestContext {
// Make contract that coinbase fees are collected into
let address: Address = rng.gen();
let salt: Salt = rng.gen();
let contract = generate(address);
let witness: Witness = contract.into();
let mut create_tx = TransactionBuilder::create(witness.clone(), salt, vec![])
.add_random_fee_input()
.finalize();
create_tx
.precompute(&ChainId::default())
.expect("tx should be valid");
let contract_id = create_tx.metadata().as_ref().unwrap().contract_id;

// Start up a node
let mut config = Config::local_node();
config.debug = true;
config.block_producer.coinbase_recipient = Some(contract_id);
let node = FuelService::new_node(config).await.unwrap();
let client = FuelClient::from(node.bound_address);

// Submit contract creation tx
let tx_status = client
.submit_and_await_commit(&create_tx.into())
.await
.unwrap();
assert!(matches!(tx_status, TransactionStatus::Success { .. }));
let bh = client.produce_blocks(1, None).await.unwrap();
assert_eq!(bh, BlockHeight::new(2));

// No fees should have been collected yet
let contract_balance =
client.contract_balance(&(contract_id), None).await.unwrap();
assert_eq!(contract_balance, 0);

TestContext {
address,
contract_id,
_node: node,
client,
}
}

/// This makes a block with a single transaction that has a fee,
/// so that the coinbase fee is collected into the contract
async fn make_block_with_fee(rng: &mut StdRng, ctx: &TestContext) {
let old_balance = ctx
.client
.contract_balance(&ctx.contract_id, None)
.await
.unwrap();

// Run a script that does nothing, but will cause fee collection
let tx = TransactionBuilder::script(
[op::ret(RegId::ONE)].into_iter().collect(),
vec![],
)
.add_unsigned_coin_input(
SecretKey::random(rng),
rng.gen(),
1000,
Default::default(),
Default::default(),
Default::default(),
)
.gas_price(1)
.script_gas_limit(1_000_000)
.finalize_as_transaction();
let tx_status = ctx.client.submit_and_await_commit(&tx).await.unwrap();
assert!(matches!(tx_status, TransactionStatus::Success { .. }));

// Now the coinbase fee should be reflected in the contract balance
let new_balance = ctx
.client
.contract_balance(&ctx.contract_id, None)
.await
.unwrap();
assert!(new_balance > old_balance);
}

async fn collect_fees(ctx: &TestContext) {
let TestContext {
client,
contract_id,
..
} = ctx;

let asset_id = AssetId::BASE;
let output_index = 1u64;
let call_struct_register = 0x10;
// Now call the fee collection contract to withdraw the fees
let script = vec![
// Point to the call structure
op::gtf_args(call_struct_register, 0x00, GTFArgs::ScriptData),
op::addi(
call_struct_register,
call_struct_register,
(asset_id.size() + output_index.size()) as u16,
),
op::call(call_struct_register, RegId::ZERO, RegId::ZERO, RegId::CGAS),
op::ret(RegId::ONE),
];

let tx = TransactionBuilder::script(
script.into_iter().collect(),asset_id.to_bytes().into_iter()
.chain(output_index.to_bytes().into_iter())
.chain(contract_id
.to_bytes().into_iter())
.chain(0u64.to_bytes().into_iter())
.chain(0u64.to_bytes().into_iter())
.collect(),
)
.add_random_fee_input() // No coinbase fee for this block
.gas_price(0)
.script_gas_limit(1_000_000)
.add_input(Input::contract(
Default::default(),
Default::default(),
Default::default(),
Default::default(),
*contract_id,
))
.add_output(Output::contract(1, Default::default(), Default::default()))
.add_output(Output::variable(
Default::default(),
Default::default(),
Default::default(),
))
.finalize_as_transaction();

let tx_status = client.submit_and_await_commit(&tx).await.unwrap();
assert!(
matches!(tx_status, TransactionStatus::Success { .. }),
"{tx_status:?}"
);
}

#[tokio::test]
async fn happy_path() {
let rng = &mut StdRng::seed_from_u64(0);

let ctx = setup(rng).await;

for _ in 0..10 {
make_block_with_fee(rng, &ctx).await;
}

// When
// Before withdrawal, the recipient's balance should be zero,
// and the contract balance should be non-zero.
let contract_balance_before_collect = ctx
.client
.contract_balance(&ctx.contract_id, None)
.await
.unwrap();
assert_ne!(contract_balance_before_collect, 0);
assert_eq!(ctx.client.balance(&ctx.address, None).await.unwrap(), 0);

// When
collect_fees(&ctx).await;

// Then

// Make sure that the full balance was been withdrawn
let contract_balance_after_collect = ctx
.client
.contract_balance(&ctx.contract_id, None)
.await
.unwrap();
assert_eq!(contract_balance_after_collect, 0);

// Make sure that the full balance was been withdrawn
assert_eq!(
ctx.client.balance(&ctx.address, None).await.unwrap(),
contract_balance_before_collect
);
}

/// Attempts fee collection when no balance has accumulated yet
#[tokio::test]
async fn no_fees_collected_yet() {
let rng = &mut StdRng::seed_from_u64(0);

let ctx = setup(rng).await;

// Given
let contract_balance_before_collect = ctx
.client
.contract_balance(&ctx.contract_id, None)
.await
.unwrap();
assert_eq!(contract_balance_before_collect, 0);
assert_eq!(ctx.client.balance(&ctx.address, None).await.unwrap(), 0);

// When
collect_fees(&ctx).await;

// Then

// Make sure that the balance is still zero
let contract_balance = ctx
.client
.contract_balance(&ctx.contract_id, None)
.await
.unwrap();
assert_eq!(contract_balance, 0);

// There were no coins to withdraw
assert_eq!(ctx.client.balance(&ctx.address, None).await.unwrap(), 0);
}

#[tokio::test]
async fn missing_variable_output() {
let rng = &mut StdRng::seed_from_u64(0);

let ctx = setup(rng).await;
make_block_with_fee(rng, &ctx).await;

let asset_id = AssetId::BASE;
let output_index = 1u64;
let call_struct_register = 0x10;

// Now call the fee collection contract to withdraw the fees,
// but unlike in the happy path, we don't add the variable output to the transaction.
let script = vec![
// Point to the call structure
op::gtf_args(call_struct_register, 0x00, GTFArgs::ScriptData),
op::addi(
call_struct_register,
call_struct_register,
(asset_id.size() + output_index.size()) as u16,
),
op::call(call_struct_register, RegId::ZERO, RegId::ZERO, RegId::CGAS),
op::ret(RegId::ONE),
];
let tx = TransactionBuilder::script(
script.into_iter().collect(),
asset_id.to_bytes().into_iter()
.chain(output_index.to_bytes().into_iter())
.chain(ctx.contract_id
.to_bytes().into_iter())
.chain(0u64.to_bytes().into_iter())
.chain(0u64.to_bytes().into_iter())
.collect(),
)
.add_random_fee_input() // No coinbase fee for this block
.gas_price(0)
.script_gas_limit(1_000_000)
.add_input(Input::contract(
Default::default(),
Default::default(),
Default::default(),
Default::default(),
ctx.contract_id,
))
.add_output(Output::contract(1, Default::default(), Default::default()))
.finalize_as_transaction();

let tx_status = ctx.client.submit_and_await_commit(&tx).await.unwrap();
let TransactionStatus::Failure { reason, .. } = tx_status else {
panic!("Expected failure");
};
assert_eq!(reason, "OutputNotFound");

// Make sure that nothing was withdrawn
let contract_balance = ctx
.client
.contract_balance(&ctx.contract_id, None)
.await
.unwrap();
assert_eq!(contract_balance, 1);
let asset_balance = ctx.client.balance(&ctx.address, None).await.unwrap();
assert_eq!(asset_balance, 0);
}
}
Loading

0 comments on commit 21cafe6

Please sign in to comment.