Add Reset to factory settings in admin page of web UI #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoseperez
reviewed
Feb 14, 2018
code/html/custom.js
Outdated
|
|
||
| ask = (typeof ask == "undefined") ? true : ask; | ||
|
|
||
| if (numChanged > 0) { |
There was a problem hiding this comment.
Unnecessary, you are about to delete all settings with the factory reset, there is no need to save changes before.
xoseperez
reviewed
Feb 14, 2018
code/html/custom.js
Outdated
| } | ||
| } | ||
|
|
||
| if (ask) { |
There was a problem hiding this comment.
Always ask. Remove the ask check (and references to the variable).
Always confirm Factory reset
|
True, that saved settings stuff was indeed useless. |
|
BTW Xose changes above are a good quick tutorial for me on how to add a button to the WEB UI, a nice and simple jump start to tinkering also on that side of the Espurna framework. |
xoseperez
approved these changes
Feb 16, 2018
|
I'm on holidays now. As soon as I'm back home I will test it and merge it. Thank you! |
Merged
xoseperez
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good useful option for the web UI