-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up output, implement timeout, do not update the whole index when deploying a branch #127
Open
GiedriusS
wants to merge
10
commits into
xorpaul:master
Choose a base branch
from
GiedriusS:g10k_fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Apr 9, 2019
-
git: do not update the whole index when deploying a branch
Update doMirrorUpdate to be able to pass a branch name to it. Pass an empty branch when we want to deploy the whole thing, and pass only a specific branch when `-branch=...` has been specified. `git fetch` does not lock the whole index and only pulls down the branch which avoids the whole plethora of issues when more than one instance of g10k is running. For example, we could run into issues like this when `git remote update --prune` is running more than once: error: Ref refs/heads/test is at 1d793f181f3a460916ce1ab5dc33e007622a9a61 but expected c28d866fdfed5be79f5ea453e04ce887627a8efa ! c28d866..1d793f1 test -> test (unable to update local ref) Also, avoiding updating the whole index means that the performance significantly improves. In my testing the whole time it takes to deploy a branch has been reduced by about 10 seconds.
Giedrius Statkevičius committedApr 9, 2019 Configuration menu - View commit details
-
Copy full SHA for adf9e78 - Browse repository at this point
Copy the full SHA adf9e78View commit details -
Update executeCommand() to leave output intact by separating two different concerns: the error and the output itself. Still always set the returnCode to 1 if any error has occurred.
Giedrius Statkevičius committedApr 9, 2019 Configuration menu - View commit details
-
Copy full SHA for c12ec68 - Browse repository at this point
Copy the full SHA c12ec68View commit details -
`timeout` is passed now down to executeCommand() but nothing is done with it. Properly make a context and pass it to exec.CommandContext(). Also, while at it add proper debug printing so that output messages *and* the error would appear in the console if `-debug=true` is specified.
Giedrius Statkevičius committedApr 9, 2019 Configuration menu - View commit details
-
Copy full SHA for 4def56b - Browse repository at this point
Copy the full SHA 4def56bView commit details
Commits on Apr 10, 2019
-
Giedrius Statkevičius committed
Apr 10, 2019 Configuration menu - View commit details
-
Copy full SHA for 64c508f - Browse repository at this point
Copy the full SHA 64c508fView commit details -
git: remove pointless --verbose
Giedrius Statkevičius committedApr 10, 2019 Configuration menu - View commit details
-
Copy full SHA for 40b5b46 - Browse repository at this point
Copy the full SHA 40b5b46View commit details -
Giedrius Statkevičius committed
Apr 10, 2019 Configuration menu - View commit details
-
Copy full SHA for 45a5fe0 - Browse repository at this point
Copy the full SHA 45a5fe0View commit details -
git: fetch the branch into the correct one
Giedrius Statkevičius committedApr 10, 2019 Configuration menu - View commit details
-
Copy full SHA for ff34716 - Browse repository at this point
Copy the full SHA ff34716View commit details
Commits on Apr 11, 2019
-
Otherwise we might run into an error like this: From https://git.foo.bar/lol.git ! [rejected] dimstoperms -> dimstoperms (non-fast-forward)
Giedrius Statkevičius committedApr 11, 2019 Configuration menu - View commit details
-
Copy full SHA for d74d4af - Browse repository at this point
Copy the full SHA d74d4afView commit details
Commits on Jul 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a87495c - Browse repository at this point
Copy the full SHA a87495cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12f7c56 - Browse repository at this point
Copy the full SHA 12f7c56View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.