-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ImplictUsings and use file-scoped namespaces #693
Conversation
@MihaZupan @xoofx Let me know what you think. If we do make this change on the main library -- it would make the change history harder to follow -- but improve the experience working with those files moving forward. |
Yeah, please go ahead in applying this to the rest of the library, it should be ok. Thanks! |
I like the feature, thanks! |
@MihaZupan Agreed on the caution -- I used the refactoring tools to do this file by file, checking them as I went along to make sure everything was indented correctly. We should be OK! |
@xoofx @MihaZupan Ready for review. I also fixed a couple spelling errors in the comments while I was double checking the indentation levels. |
Here's a direct link to review ignoring whitespace changes: https://github.com/xoofx/markdig/pull/693/files?diff=unified&w=1 |
Thanks a lot! |
This PR is up for feedback on whether we should enable file-scoped namespaces on some of all of the markdig projects.
Pulling the indentation in 4 lines on the tests is a fairly nice improvement for readability -- particularly on a 15" laptop.