Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version "Unknown" if AssemblyFileVersionAttribute is missing #600

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

gauss-lvs-dev
Copy link

Hey,

i know it's not markdigs fault, if the AssemblyFileVersionAttribute is missing on Xamarin.iOS. But I thought it is unfortunate that markdig won't work just because it was not able to get the version string. Besides that missing AssemblyFileVersionAttribute markdig works well on Xamarin.iOS. At least with the markdown documents I tested.

Kind regards

@coveralls
Copy link

coveralls commented Mar 3, 2022

Pull Request Test Coverage Report for Build 1921325883

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 93.008%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Markdig/Markdown.cs 0 5 0.0%
Totals Coverage Status
Change from base Build 1914785789: -0.04%
Covered Lines: 24661
Relevant Lines: 25911

💛 - Coveralls

@xoofx xoofx merged commit a3f21b7 into xoofx:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants