Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when Yarn is not installed and the project is using Yarn #17

Merged
merged 4 commits into from
Sep 26, 2019
Merged

Warn when Yarn is not installed and the project is using Yarn #17

merged 4 commits into from
Sep 26, 2019

Conversation

07Gond
Copy link
Contributor

@07Gond 07Gond commented Oct 6, 2018

Closes xojs/xo#325

@07Gond 07Gond mentioned this pull request Oct 6, 2018
Closed
@07Gond
Copy link
Contributor Author

07Gond commented Oct 6, 2018

Hi @sindresorhus
There are some lint errors that are not mine but I can fix them.
Do I send it like commits on this PR?

sindresorhus
sindresorhus requested changes Oct 13, 2018
View reviewed changes
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Member

There are some lint errors that are not mine but I can fix them.

Fixed in master branch. Just rebase from master.

sindresorhus
sindresorhus reviewed Oct 15, 2018
View reviewed changes
index.js Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Oct 15, 2018
View reviewed changes
index.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Member

Looks like you didn't correctly rebase. The diff contains unrelated commits: https://github.com/xojs/xo-init/pull/17/files

@07Gond
Copy link
Contributor Author

07Gond commented Nov 17, 2018

@sindresorhus Hi! I just updated the code.

@sindresorhus sindresorhus changed the title Send msg on error catch yarn exec Warn when Yarn is not installed and you're in a Yarn project Sep 26, 2019
@sindresorhus sindresorhus changed the title Warn when Yarn is not installed and you're in a Yarn project Warn when Yarn is not installed and the project is using Yarn Sep 26, 2019
@sindresorhus sindresorhus merged commit 6090a3f into xojs:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xo --init crashes out if yarn.lock is present but yarn isn't available
2 participants
@07Gond @sindresorhus