Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll* props should not be passed down to div #68

Closed
bz2 opened this issue May 23, 2019 · 0 comments · Fixed by #69
Closed

scroll* props should not be passed down to div #68

bz2 opened this issue May 23, 2019 · 0 comments · Fixed by #69

Comments

@bz2
Copy link

bz2 commented May 23, 2019

Steps

  • <Scrollbar scrollTop={0}/>
  • Check prop-types.

Current behaviour

Warning displayed in console:

console.error node_modules/jest-prop-type-error/index.js:8
      Warning: React does not recognize the `scrollTop` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `scrolltop` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
          in div (created by Scrollbar)
          in Scrollbar (created by Scrollbars)
          ...

Expected behaviour

No warning in console.

JSFiddle

Not possible(?) as there's no UMD react-scrollbars-custom, but example with just <div/>: https://jsfiddle.net/jtrmc6wz/

Versions

  • react-scrollbars-custom 4.0.0-alpha.19

See also

#63 Fixed same issue with a different prop that should be consumed at the Scrollbar level.

xobotyi added a commit that referenced this issue May 24, 2019
@xobotyi xobotyi mentioned this issue May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant