Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create OR REPLACE transient/temporary TABLE not recognized by parser #133

Closed
devxor opened this issue Jun 7, 2022 · 8 comments
Closed

Comments

@devxor
Copy link

devxor commented Jun 7, 2022

Describe the bug
"create OR REPLACE transient/temporary table" not recognized by parser.
Thx for quickly adding the support for "OR REPLACE TABLE"!
It seems that the "OR REPLACE" is only working with the "TABLE", but not with the Snowflake specific "TRANSIENT TABLE" or "TEMPORARY TABLE". However the support for snowflake's transient/temporary table is there e.g. "create TRANSIENT/TEMPORARY table" is working properly.
Snowflake Docs: Working with Temporary and Transient Tables

To Reproduce

CREATE OR REPLACE TRANSIENT TABLE someTable (
    someField VARCHAR(4)
)
CREATE OR REPLACE TEMPORARY TABLE someTable (
    someField VARCHAR(4)
)

Expected behavior
To get a proper output from the parser.

@xnuinside
Copy link
Owner

@devxor aha ) because they are not added as statements - will do it today!

@devxor
Copy link
Author

devxor commented Jun 7, 2022

Thx for the quick response!

@devxor
Copy link
Author

devxor commented Jun 9, 2022

@xnuinside Hi! Sorry for asking, but when you will have time for the fix? Thx!

@xnuinside
Copy link
Owner

@devxor sorry, didn't have a chance yesterday, will try today

@xnuinside
Copy link
Owner

@devxor it wasn't so fast as I expected )) need to work on it little bit today also

xnuinside added a commit that referenced this issue Jun 10, 2022
@xnuinside xnuinside mentioned this issue Jun 10, 2022
xnuinside added a commit that referenced this issue Jun 10, 2022
@xnuinside
Copy link
Owner

already released on 0.26.4, test - https://github.com/xnuinside/simple-ddl-parser/blob/main/tests/test_simple_ddl_parser.py#L2772 and sorry for the delay :)

@xnuinside
Copy link
Owner

I will close the issue, will free open new) if you have some special DDL you need to parse - you can share it full & I will check if something didn't supported yet, and will add it

@devxor
Copy link
Author

devxor commented Jun 10, 2022

@xnuinside thank you very much! It's working now! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants