feat: permit creating client from exported key bundle #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmccartney
commented
Jun 21, 2023
| @@ -2,164 +2,181 @@ import ExpoModulesCore | |||
| import XMTP | |||
|
|
|||
| class ReactNativeSigner: NSObject, XMTP.SigningKey { | |||
| enum Error: Swift.Error { | |||
There was a problem hiding this comment.
most of the changes in this file are just replacing \t with 4 spaces
dmccartney
commented
Jun 21, 2023
Comment on lines
+135
to
+151
| // Create a client using its serialized key bundle. | ||
| AsyncFunction("createFromKeyBundle") { (keyBundle: String, environment: String) -> String in | ||
| let bundle = try PrivateKeyBundle(serializedData: Data(base64Encoded: Data(keyBundle.utf8))!) | ||
| let options = XMTP.ClientOptions(api: apiEnvironments[environment] ?? apiEnvironments["dev"]!) | ||
| let client = try await Client.from(bundle: bundle, options: options) | ||
| self.clients[client.address] = client | ||
| return client.address | ||
| } | ||
|
|
||
| // Export the client's serialized key bundle. | ||
| AsyncFunction("exportKeyBundle") { (clientAddress: String) -> String in | ||
| guard let client = clients[clientAddress] else { | ||
| throw Error.noClient | ||
| } | ||
| let bundle = try client.privateKeyBundle.serializedData().base64EncodedString() | ||
| return bundle | ||
| } |
There was a problem hiding this comment.
These are the substantive changes.
nplasterer
approved these changes
Jun 21, 2023
dmccartney
force-pushed
the
daniel-create-export-keybundle
branch
from
3b82e5d to
7ebfec8
Compare
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
createFromKeyBundleandexportKeyBundleto theClient.This is part of the solution for #35