Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename senderAddress to senderInboxId #574

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Rename senderAddress to senderInboxId #574

merged 3 commits into from
Dec 18, 2024

Conversation

nplasterer
Copy link
Contributor

Rename to make it more clear

@nplasterer nplasterer self-assigned this Dec 18, 2024
@nplasterer nplasterer requested a review from a team as a code owner December 18, 2024 06:25
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4acbb5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Base automatically changed from np/consent-filtering-conversation-syncing to main December 18, 2024 16:08
@nplasterer nplasterer merged commit dfd819f into main Dec 18, 2024
5 of 6 checks passed
@nplasterer nplasterer deleted the np/rename-sender-address branch December 18, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchenani mchenani mchenani approved these changes

Assignees

@nplasterer nplasterer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nplasterer @mchenani