Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permissions admin and super admin lists #397

Merged
merged 4 commits into from
May 30, 2024
Merged

Permissions admin and super admin lists #397

merged 4 commits into from
May 30, 2024

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented May 30, 2024 •
edited
Loading

RN part of xmtp/libxmtp#664

Android - xmtp/xmtp-android#245
iOS - xmtp/xmtp-ios#341

PR adds the following

  • isAdmin / isSuperAdmin
  • adminList() \ superAdminList()
  • add / remove admin
  • creatorInboxId(), removes isCreator()

New tests:

image

@cameronvoell cameronvoell requested review from humanagent and a team as code owners May 30, 2024 21:38
@cameronvoell cameronvoell changed the base branch from main to beta May 30, 2024 21:39
@cameronvoell cameronvoell merged commit dc6690e into beta May 30, 2024
5 of 6 checks passed
@cameronvoell cameronvoell deleted the cv/permissions-admin-super-admin-lists branch May 30, 2024 21:53
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.34.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrisch alexrisch alexrisch approved these changes

@nplasterer nplasterer nplasterer approved these changes

@humanagent humanagent Awaiting requested review from humanagent

Assignees
No one assigned
Labels
Group Chat - Prod released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cameronvoell @nplasterer @alexrisch @bwcDvorak