feat: New V3 Identity #395
Conversation
…ative into np/v3-identity
| val cacheGroup = groups[cacheKey] | ||
| if (cacheGroup != null) { | ||
| return cacheGroup | ||
| } else { | ||
| val group = client.conversations.listGroups() | ||
| .firstOrNull { it.id.toHex() == id } | ||
| if (group != null) { | ||
| groups[group.cacheKey(clientAddress)] = group | ||
| groups[group.cacheKey(client.inboxId)] = group |
There was a problem hiding this comment.
Think this needs to be updated on line 516 as well:
| @@ -197,8 +215,8 @@ export class Group< | |||
|
|
|||
| // Returns the address that added you to the group. | |||
| // To get the latest added by address from the network, call sync() first. | |||
There was a problem hiding this comment.
update comments here for inbox id
|
|
||
| export type ExtractDecodedType<C> = | ||
| C extends XMTPModule.ContentCodec<infer T> ? T : never | ||
| export type ExtractDecodedType<C> = C extends XMTPModule.ContentCodec<infer T> |
There was a problem hiding this comment.
can fix these lint warnings with yarn run eslint --fix from root proj directory
|
There are a bunch of tests failing because members() func was not returning properly (issue) in some cases and that was fixed in a libxmtp update yesterday in this PR - xmtp/libxmtp#781 I'm thinking it's okay to merge this, but we should follow up with another android/ios releases to get in latest libxmtp, or we can wait with this PR, wdyt @nplasterer ? |
|
|
|
🎉 This PR is included in version 1.34.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Uses the new V3 Identity for Groups. Gets rid of accountAddress in favor of inboxId.
Will add support for smart contract wallets in a follow up PR.