Stream All Group Messages #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| await boGroup.send({ text: `Message ${i}` }) | ||
| await delayToPropogate() | ||
| } | ||
| if (allMessages.length <= 10) { |
There was a problem hiding this comment.
This test was failing for me here. Think it's supposed to be greater than, to verify that cancellation worked?
Hmm. Actually it's only failing for me on Android. Digging in a bit more now, might just need a delay for a slow emulator.
Co-authored-by: Cameron Voell <[email protected]>
cameronvoell
approved these changes
Feb 21, 2024
|
🎉 This PR is included in version 1.28.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.30.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.31.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to stream all group messages and to stream all messages including groups.