Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Testing #28

Merged
merged 12 commits into from
May 9, 2023
Merged

Android Testing #28

merged 12 commits into from
May 9, 2023

Conversation

nplasterer
Copy link
Contributor

@nplasterer nplasterer commented May 5, 2023

This is the android part of #25

Sceenshots can be found in DeviceFileExplorer/storage/emulated/0/googletest/test_outputfiles/MainActivityTest_testRunTests.png

This gets the tests passing as well as a integration test for running it.
Will do github action with CI in a follow up.

@nplasterer nplasterer self-assigned this May 5, 2023
@nplasterer nplasterer marked this pull request as ready for review May 9, 2023 19:29
@nplasterer nplasterer requested a review from a team as a code owner May 9, 2023 19:29
<Button
onPress={() => setIsTesting(true)}
title="Unit tests"
accessibilityLabel="Unit-tests"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accessibilityLabels need to be added so the android espresso tests can find things.

@nplasterer nplasterer merged commit 3022dc9 into main May 9, 2023
@nplasterer nplasterer deleted the np/android-testing branch May 9, 2023 19:36
Copy link
Contributor

@nakajima nakajima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on this!

@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants