Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Custom Content Types when preparing messages #198

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

alexrisch
Copy link
Contributor

Added logic in Conversation to handle content type in prepare method Updated bridged module to handle encrypted messages

Requires iOS Sdk Change: xmtp/xmtp-ios#212
Requires Android Sdk Change: xmtp/xmtp-android#150

Added logic in Conversation to handle content type in prepare method
Updated bridged module to handle encrypted messages

Requires iOS Sdk Change: xmtp/xmtp-ios#212
Requires Android Sdk Change:
@alexrisch alexrisch requested a review from a team as a code owner January 2, 2024 22:32
Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation looks correct to me. Once iOS and Android land this LGTM. 👍

Alex Risch added 2 commits January 2, 2024 19:16
Added logic in Conversation to handle content type in prepare method
Updated bridged module to handle encrypted messages

Requires iOS Sdk Change: xmtp/xmtp-ios#212
Requires Android Sdk Change:
@alexrisch alexrisch merged commit 8021f6b into main Jan 3, 2024
4 of 5 checks passed
@alexrisch alexrisch deleted the user/alexrisch/custom-content-prepare branch January 3, 2024 04:04
Copy link
Contributor

github-actions bot commented Jan 3, 2024

🎉 This PR is included in version 1.23.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants