Fix decoding messages #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
commented
Dec 20, 2023
| throw new Error( | ||
| `no content type found ${JSON.stringify(this.contentTypeId)}` | ||
| ) | ||
| } |
There was a problem hiding this comment.
Fix for custom content types.
nplasterer
commented
Dec 20, 2023
| if ('contentKey' in codec && this.nativeContent[codec.contentKey]) { | ||
| if ( | ||
| ('contentKey' in codec && this.nativeContent[codec.contentKey]) || | ||
| this.nativeContent.hasOwnProperty('text') |
There was a problem hiding this comment.
Text is always a supported content type.
nakajima
approved these changes
Dec 20, 2023
|
🎉 This PR is included in version 1.23.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending a text message with an empty string the app would error as the string was considered falsy since it was empty. We now handle all text messages as they are supported by default.
In this process I also caught that custom content types would break on decode because the codec did not exist. We now error gracefully for unsupported content types allowing for the handling of them in app.