Remove Manual Install Step #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: There are a number of manual steps required when integrating with React Native SDK Would like to make sure that this is indeed a requirement or if we can smooth out integration steps Solution: Move dependency to podspec Remove ReadMe step
cameronvoell
approved these changes
Dec 19, 2023
nplasterer
approved these changes
Dec 19, 2023
|
cc @nakajima for visibility, I am guessing since the builds were successful and tests were too the change should be fine and confident to merge, but do you have any gotcha's? |
|
I think this is okay to merge. Signaling to @fabriguespe that this step should no longer be needed. |
|
🎉 This PR is included in version 1.23.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
There are a number of manual steps required when integrating with React Native SDK
Would like to make sure that this is indeed a requirement or if we can smooth out integration steps
Solution:
Move dependency to podspec
Remove ReadMe step
Opening as draft to see how CI handles this change