Proposal : unsubscribe all message & conversation event #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kele-leanes
force-pushed
the
kele/unsubscribe-from-conversation
branch
from
51581e3 to
d06d5f6
Compare
cameronvoell
previously approved these changes
Dec 19, 2023
cameronvoell
dismissed
their stale review
downstream clients may be using cancelStream functions, need to revise strategy here
|
I'll go ahead and close this one, as issues with cancelStream functions was addressed in a PR here: #290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Building upon the insights gained from issue #187, this pull request introduces a refined approach to proper unsubscription from the methods returned by
streamandstreamAllMessages. Simultaneously, it recommends the removal of the static methodscancelStream()andcancelStreamAllMessages().This adjustment serves to eliminate redundant listeners and prevent the occurrence of duplicated events.