Fix Resolutions & Move to Yarn #185
Conversation
Problem: NPM forces us to jump through number of hoops We seen an issue when dealing with React peer dependencies but they do not get handled appropriately This is actually also seen in new expo modules created through the create-expo-module cli Solution: Stop forcing dependencies and working around dependency resolution and simply use yarn Changes: Removed package-lock.json updated docs to point user towards yarn Fix readme for npm pod-install to npx pod-install
alexrisch
force-pushed
the
user/alexrisch-yarn-and-resolutions
branch
from
a4e8fbb to
f09b5fb
Compare
|
looks like this is using Yarn v1. why not Yarn v4? |
I still only have v1 setup and it still seems to be the stable version: https://classic.yarnpkg.com/lang/en/docs/install/#mac-stable |
v1 has been in maintenance mode since 1/2020. latest version now is 4.0.2, which requires corepack to be enabled. just need to run that should hopefully just work. there are some GH actions updates as well. happy to sync on this if you'd like. |
|
I propose we merge this with yarn v1 because it's the yarn setup linked to from Expo docs, and we know it resolves a build issue that is currently merged on main, and the CI is working as is in this PR, and then we do a follow up issue for migrating from yarn v1 to yarn v4 => https://yarnpkg.com/migration/guide That way we can resolve the build issue that is merged to main right now, without having to make sure that our expo setup and CLI has any issues with yarn v4. thoughts? @rygine @alexrisch |
sounds good! |
|
🎉 This PR is included in version 1.23.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Problem:
NPM forces us to jump through a number of hoops
We seen an issue when dealing with React peer dependencies but they do not get handled appropriately
This is actually also seen in new expo modules created through the create-expo-module cli
Solution:
Stop forcing dependencies and working around dependency resolution and simply use yarn
Changes:
Removed package-lock.json
updated docs to point user towards yarn
Fix readme for npm pod-install to npx pod-install
Fixes Issues with Hooks addition from this #178 & identified on here #177