Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions for running local xmtp server/unit tests locally #173

Merged
merged 8 commits into from
Dec 8, 2023

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Dec 7, 2023

See updated README.md and new example/README.md.

My thinking here is to get commands used for running and testing the Example app explicit stated in the repo. Feedback welcomed!

example/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@alexrisch alexrisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@jhaaaa jhaaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to provide these meaningful docs, @cameronvoell! Just added a few suggested tech writer-type style edits 🤓

example/README.md Outdated Show resolved Hide resolved
example/README.md Outdated Show resolved Hide resolved
example/README.md Outdated Show resolved Hide resolved
example/README.md Outdated Show resolved Hide resolved
example/README.md Outdated Show resolved Hide resolved
example/README.md Outdated Show resolved Hide resolved
example/README.md Outdated Show resolved Hide resolved
@cameronvoell
Copy link
Contributor Author

Thank you for taking the time to provide these meaningful docs, @cameronvoell! Just added a few suggested tech writer-type style edits 🤓

@jhaaaa thanks so much, applied your edits (very helpful!), and will go ahead and merge now 🙇

@cameronvoell cameronvoell merged commit cebc2d5 into main Dec 8, 2023
4 of 5 checks passed
@cameronvoell cameronvoell deleted the cameronvoell/add-local-unit-test-readme branch December 8, 2023 18:55
Copy link
Contributor

🎉 This PR is included in version 1.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants