Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated example app to react-native 0.71.14 #172

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Dec 7, 2023

Fixes #171

Note the changes in this PR are all a result of updating react-native version in example/package.json to 0.71.14 and running npm install + running the ios example app.

Unit tests all passing

For reference, RN Upgrade helper doesn't seem to show anything else relevant for us. => https://react-native-community.github.io/upgrade-helper/?from=0.71.8&to=0.71.14

CleanShot 2023-12-07 at 09 05 08

@cameronvoell
Copy link
Contributor Author

cameronvoell commented Dec 7, 2023

@daria-github @nplasterer Are there any additional ways we would want to test a RN version update like this other than in the example app / unit tests? Wondering if we have any formal or informal procedures for reaching out to integration clients for example.

@cameronvoell cameronvoell marked this pull request as ready for review December 7, 2023 17:16
@cameronvoell cameronvoell requested a review from a team as a code owner December 7, 2023 17:16
@nplasterer
Copy link
Contributor

nplasterer commented Dec 7, 2023

@cameronvoell is the concern that this would break integrators who don't support the latest RN version? This probably goes hand in hand with @rygine suggestion to make a beta channel for RN like we have in JS. Especially as we make more potentially breaking changes like this. I also want to note that we do semantic releases here so if you don't include a commit with feat: or fix: it won't cut a new release.

@cameronvoell
Copy link
Contributor Author

@cameronvoell is the concern that this would break integrators who don't support the latest RN version? This probably goes hand in hand with @rygine suggestion to make a beta channel for RN like we have in JS. Especially as we make more potentially breaking changes like this.

@nplasterer Yes this is the type of concern I was referencing, though I think this particular RN upgrade looks low risk, I figured it was a good time to ask. I like the idea of having a beta channel for releases like we how do in xmtp-js. Created an issue here for adding beta releases, will take a look at whats required.

I also want to note that we do semantic releases here so if you don't include a commit with feat: or fix: it won't cut a new release.

Ah perfect, I'll review the semantic release setup and let team know if anything seems unclear. For this fix, cutting a new release doesn't seem necessary. Thanks!

@cameronvoell cameronvoell merged commit b1af48e into main Dec 8, 2023
4 of 5 checks passed
@cameronvoell cameronvoell deleted the cameronvoell/update-react-native-0.71.14 branch December 8, 2023 19:06
Copy link
Contributor

🎉 This PR is included in version 1.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Xcode 15 fails to build Example app for iOS because of boost C++ bug
3 participants