Example App - Live Update Deny #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronvoell
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
The live update of denied status works great, nice fix!
Color update on Android is helpful as well.
I noticed that the selectable prop does not seem to be working for me on Android (tested on emulator and device, neither worked for me). It does make the text copy-able on iOS though, so still an improvement. Perhaps we can look at adding a copy button in some follow up PR later, since that prop seems to have some issues on Android.
Nice work!
Added request after denying the conversation to set state on the conversation item Made wallet string selectable for easier developing Fixed Android Button styling on home screen
alexrisch
force-pushed
the
user/alexrisch/live-update-deny
branch
from
15e2792 to
b6bb12e
Compare
nplasterer
approved these changes
Dec 8, 2023
|
🎉 This PR is included in version 1.22.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #160
Added request after denying the conversation to set state on the conversation item
Made wallet string selectable for easier developing
Fixed Android Button styling on home screen
Screen.Recording.2023-12-06.at.3.23.06.PM.mov