feat: allow numeric timestamp in listMessages #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
reviewed
Oct 27, 2023
There was a problem hiding this comment.
Hey thanks for your contribution! It looks good but would you mind updating or adding a test in this file to make sure it still works across the iOS and Android bridge 🙏
https://github.com/xmtp/xmtp-react-native/blob/main/example/src/tests.ts#L30-L69
|
Hey @peterferguson just nudging on this to see if you have time to add the tests? Let me know. 🙏 |
|
Hey @nplasterer I pushed a test but I haven't actually been able to run it. I didn't see a test command & also simulator builds with this repo in them fail on my machine (see related post) |
nplasterer
approved these changes
Nov 8, 2023
|
🎉 This PR is included in version 1.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying messages based on Dates the timestamps are usually coming from a local cache (in our case, but I assume in most others too).
In order to avoid multiple conversions
number/string->Date->number, I think it makes sense to allow the users to pass a number tolistMessages&listBatchMessages.