+ Typescript Cleanup #118
Merged
+ Typescript Cleanup #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rygine
reviewed
Sep 17, 2023
example/src/XmtpContext.tsx
Outdated
| @@ -9,7 +9,7 @@ const XmtpContext = createContext<{ | |||
| setClient: () => {}, | |||
| }); | |||
| export const useXmtp = () => useContext(XmtpContext); | |||
| export function XmtpContextProvider({ children }) { | |||
| export const XmtpContextProvider: FC<any> = ({ children }) => { | |||
There was a problem hiding this comment.
i think FC<PropsWithChildren> would work better here
There was a problem hiding this comment.
ahhh yes, I missed that..
rygine
reviewed
Sep 20, 2023
| type Props = { | ||
| children: ReactNode | ||
| } | ||
| export const XmtpContextProvider: FC<Props> = ({ children }) => { |
There was a problem hiding this comment.
FYI, PropsWithChildren is an official export from react
rygine
approved these changes
Sep 20, 2023
|
🎉 This PR is included in version 1.16.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will cleanup most of the typescript issue in the example folder