Group Preferences Actions #272
Conversation
| public var senderHmac: Data { | ||
| get {return _senderHmac ?? Data()} | ||
| set {_senderHmac = newValue} | ||
| } | ||
| /// Returns true if `senderHmac` has been explicitly set. | ||
| public var hasSenderHmac: Bool {return self._senderHmac != nil} | ||
| /// Clears the value of `senderHmac`. Subsequent reads from it will return its default value. | ||
| public mutating func clearSenderHmac() {self._senderHmac = nil} |
There was a problem hiding this comment.
Is this related to this PR? I'm curious why this is needed here.
There was a problem hiding this comment.
That was included in the required protobuf bump: 1eab635
See my answer inline regarding the question. Thank you kindly for your time and attention to the review! 🫶🏼 |
|
@zombieobject Sorry for the late review on this. But looks like you missed updating one place This whole method needs to be rewritten to better align with Android. https://github.com/xmtp/xmtp-android/blob/main/library/src/main/java/org/xmtp/android/library/Conversation.kt#L91-L97 Could you do this in a follow up PR? |
@nplasterer Thank you kindly for the time to review and the feedback. I'll be sure to follow up with a patch PR! Update: Thanks for linking the diffs there. I can see clearly where the changes are needed. I think that I was only looking at the original PR and occasionally referencing the current source on Android at the time. Either way, I will improve my approach to diffing the changes between what was submitted in prior PR's vs what is currently in Android main at the time of my implementation. This was great run at learning how the team works and I enjoy this attention to detail! |
When implementing change for Group Preferences Actions, the consentState function was not updated. See PR: #272
|
@nplasterer - Patch PR for these changes ready: #275 |
When implementing change for Group Preferences Actions, the consentState function was not updated. See PR: #272
Introduction 📟
This Pull Request is intended to add Consent/Deny functionality to actions related to Group Messaging.
Discussion 🎙
The implementation follows closely with the work completed in the following Android SDK Pull Request