Fix peer addresses actually returns peer addresses #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronvoell
approved these changes
Feb 22, 2024
| @@ -82,6 +82,14 @@ public struct Group: Identifiable, Equatable, Hashable { | |||
| return [] | |||
| } | |||
| } | |||
|
|
|||
| public var peerAddresses: [String] { | |||
There was a problem hiding this comment.
when reading this, it wasn't clear to me ( initially ) that this is the "other conversation members peer addresses" list. not sure if it's a good idea or not, but the memberAddresses.map(\.localizedLowercase) seems to be error prone, as it might create different address representation to the same address. Ideally, it would be lower-cased at the source.
There was a problem hiding this comment.
That would be ideal but since we haven't been lowercasing from the beginning it's not that easy and would potentially break existing clients. Something we can strive for when we move to v3 tho.
kele-leanes
pushed a commit
that referenced
this pull request
Feb 23, 2024
* peer addresses was not removing self from list * bump the pod * dry it up
kele-leanes
pushed a commit
that referenced
this pull request
Feb 23, 2024
* peer addresses was not removing self from list * bump the pod * dry it up
kele-leanes
pushed a commit
that referenced
this pull request
Feb 23, 2024
* peer addresses was not removing self from list * bump the pod * dry it up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't removing self correctly