Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing DB Path #260

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Fix passing DB Path #260

merged 4 commits into from
Feb 21, 2024

Conversation

nplasterer
Copy link
Contributor

Forgot to add the dbPath to the init function.
Also adds tests around it.

@nplasterer nplasterer self-assigned this Feb 21, 2024
@nplasterer nplasterer requested a review from a team as a code owner February 21, 2024 15:41
@nplasterer nplasterer merged commit 353604a into main Feb 21, 2024
1 check passed
@nplasterer nplasterer deleted the np/fix-passing-db-path branch February 21, 2024 16:29
Copy link
Contributor

@zombieobject zombieobject left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM!

kele-leanes pushed a commit that referenced this pull request Feb 23, 2024
* fix up the db path on init

* bump the pod spec

* add a test for it

* write a test for it
kele-leanes pushed a commit that referenced this pull request Feb 23, 2024
* fix up the db path on init

* bump the pod spec

* add a test for it

* write a test for it
kele-leanes pushed a commit that referenced this pull request Feb 23, 2024
* fix up the db path on init

* bump the pod spec

* add a test for it

* write a test for it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants