Removing conversations that contain a no valid topic #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
reviewed
Nov 25, 2023
There was a problem hiding this comment.
Do you mind bumping the podfile like what I did here: #193 so we can get these changes into react native as well.
Also looks like a legit lint error.
Co-authored-by: Naomi Plasterer <[email protected]>
Update pod version to trigger the build
nakajima
reviewed
Nov 27, 2023
rygine
reviewed
Nov 29, 2023
| @@ -39,4 +39,8 @@ public enum Topic { | |||
| private func wrap(_ value: String) -> String { | |||
| "/xmtp/0/\(value)/proto" | |||
| } | |||
|
|
|||
| static func isValidTopic(topic: String) -> Bool { | |||
| return topic.allSatisfy(\.isASCII) | |||
There was a problem hiding this comment.
also commented on the Android PR on this. do we want to allow characters 0-32 in topics?
nakajima
approved these changes
Nov 30, 2023
…x/conversations_with_invalid_topics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expectations