Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message refactor and cleanup #360

Merged
merged 16 commits into from
Jan 7, 2025
Merged

Message refactor and cleanup #360

merged 16 commits into from
Jan 7, 2025

Conversation

nplasterer
Copy link
Contributor

@nplasterer nplasterer commented Jan 6, 2025

Remove DecodedMessages in favor of just Messages and cleans up some incorrect imports.

@nplasterer nplasterer self-assigned this Jan 6, 2025
@nplasterer nplasterer changed the base branch from main to np/conversation-list-performance January 6, 2025 22:42
@nplasterer nplasterer marked this pull request as ready for review January 7, 2025 00:52
@nplasterer nplasterer requested a review from a team as a code owner January 7, 2025 00:52
@cameronvoell cameronvoell self-requested a review January 7, 2025 01:44
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the cleanup - one suggestion about decoding in Message constructor instead of the content function

Base automatically changed from np/conversation-list-performance to main January 7, 2025 02:13
@nplasterer nplasterer merged commit bcc15c4 into main Jan 7, 2025
4 of 5 checks passed
@nplasterer nplasterer deleted the np/message-cleanup branch January 7, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants