Signature verification #334
Conversation
| assertEquals( | ||
| fixtures.boClient.verifySignatureWithInstallationId( | ||
| "Testing", | ||
| signature, | ||
| alixInstallationId | ||
| ), true | ||
| ) |
There was a problem hiding this comment.
This feels weird that it's true? Should Bo really be able to verify if a signature was made by alix's installationId?
| } | ||
| } | ||
|
|
||
| fun verifySignatureWithInstallationId(message: String, signature: ByteArray, installationId: String): Boolean { |
There was a problem hiding this comment.
Sorry, I missed this when I approved. Can we rename this function to match with the ffi client?
There was a problem hiding this comment.
Or I can rename the fn on the client if it's confusing. I'm fine with going with the nomenclature you went with on ios.
There was a problem hiding this comment.
I think it's confusing for integrators since it's not clear that the installationId is the public key. I think it's okay for the names between the SDKs and libxmtp to differ. This isn't the first time I've strayed from the ffi naming in benefits of clarity in the sdk.
Adds the ability to verify if a signature was signed or not by a key