Consent V3 #297
Consent V3 #297
Conversation
| if (client.v3Client != null) { | ||
| setV3ConsentState(entries) | ||
| } | ||
| if (client.hasV2Client) { |
There was a problem hiding this comment.
This is in prep for when we have SCW. Only publish if we have a V2 client.
| entries.forEach { | ||
| client.v3Client?.setConsentState( | ||
| ConsentState.toFfiConsentState(it.consentType), | ||
| EntryType.toFfiConsentEntityType(it.entryType), | ||
| it.value | ||
| ) | ||
| } |
There was a problem hiding this comment.
For performance reasons in this interim period of V2 and V3 we might want to add a FFibinding for setting a list so we dont have to iterate.
| @@ -270,7 +346,8 @@ data class Contacts( | |||
| ) { | |||
|
|
|||
| suspend fun refreshConsentList(): ConsentList { | |||
| consentList.load() | |||
| val entries = consentList.load() | |||
| consentList.setV3ConsentState(entries) | |||
There was a problem hiding this comment.
After loading the V2 consent add them all to the V3 database.
| suspend fun state(address: String): ConsentState { | ||
| client.v3Client?.let { | ||
| return ConsentState.fromFfiConsentState( | ||
| it.getConsentState( | ||
| FfiConsentEntityType.ADDRESS, | ||
| address | ||
| ) | ||
| ) | ||
| } | ||
| val entry = entries[ConsentListEntry.address(address).key] | ||
|
|
||
| return entry?.consentType ?: ConsentState.UNKNOWN |
There was a problem hiding this comment.
Previously it was checking this local entries list which we could still just do since we write to both. But I like move towards checking the V3 state only since that should be the ultimate source of truth if you have V3.
| var dbPath: String = "" | ||
| lateinit var inboxId: String | ||
| var hasV2Client: Boolean = false |
There was a problem hiding this comment.
Just a nit - looks like it is currently impossible to create a Client without hasV2Client being true, but it is pretty hard to tell that from this code. (you need to check that all functions that return Client either call buildFromV1Bundle or loadOrCreateKeys)
Since currently all code paths set this to true, I wonder if we should just set it to true by default, instead of false, and add the hasV2Client = false later on when there is a path that actually makes this possible.
There was a problem hiding this comment.
Hmmm you know this is a good point. I actually think it's going to be really hard to validate the correctness of all our work without having the ability to make a pure v3 client. I'm going to open a separate PR today that so that we can make certain this stuff is working like expected in V3 and not just a side effect of the dual sending.
There was a problem hiding this comment.
From creating this PR I align with you it should be defaulted to true https://github.com/xmtp/xmtp-android/pull/298/files
Part of xmtp/libxmtp#801
This adds the ability to get and set consent records in V3
Dual sends so we are always setting both V2 and V3 consent. And adds a check to see if a V2Client is present to support pure V3 clients.