feat: Rust V2 #219
feat: Rust V2 #219
Conversation
|
|
||
| override suspend fun subscribe(topics: List<String>): Flow<Envelope> = flow { | ||
| try { | ||
| val subscription = rustV2Client.subscribe(FfiV2SubscribeRequest(topics)) |
There was a problem hiding this comment.
For some reason Rust hangs in the tests on these subscribe methods. I had to rework several of the tests to get this to show correctly.
There was a problem hiding this comment.
I toyed with the idea of spinning up a Android GRPC channel just for the subscribe stuff since it feels better than this rust subscribe work. But thought it would be better to just remove the dependency on android grpc entirely. Curious others thoughts.
There was a problem hiding this comment.
That's a little scary. Have you been able to test this with the example app to see if it's the tests or the implementation?
There was a problem hiding this comment.
Ya I ran into this with Groups as well. Everything seems to work when not using the turbine coroutine test methods. But it does make me desire a beta branch for changes like this.
There was a problem hiding this comment.
And yes the example app works with streaming.
|
I didn't feel comfortable with the major overhaul of streaming here. So decided to bring back the grpc stuff just for streaming. I still think this is an improvement and have confirmed streams still work as expected. I think I will merge this as an incremental step and open another PR for just the subscribe bits so that we can test them in isolation. |
| @@ -182,6 +183,7 @@ class MainActivity : AppCompatActivity(), | |||
|
|
|||
| private fun showError(message: String) { | |||
| val error = message.ifBlank { resources.getString(R.string.error) } | |||
| Log.e("MainActivity", message) | |||
There was a problem hiding this comment.
Ya it helps with logging errors in the example. Otherwise it just says "An Error Happened" with no details.
| 7. Copy the jniLibs from `libxmtp/bindings_ffi/jniLibs` to `xmtp-android/library/src/main/jniLibs` | ||
| ## Process for updating from a [libxmtp](https://github.com/xmtp/libxmtp) Kotlin Binding Release | ||
|
|
||
| 1. From repo [libxmtp](https://github.com/xmtp/libxmtp) run the [kotlin release action](https://github.com/xmtp/libxmtp/actions/workflows/release-kotlin-bindings.yml) for the branch you desire |
There was a problem hiding this comment.
nice excited to try this!
| environment = clientOptions.api.env, | ||
| secure = clientOptions.api.isSecure, | ||
| ) | ||
| val v2Client = runBlocking { |
There was a problem hiding this comment.
question - is there a reason we use runBlocking instead of making canMessage a suspend function? I know we previously had more runBlocking, but I think we pulled them out because we thought we had better performance with using suspend functions in some cases. same would apply to the other runBlocking in this class.
Part of: #223
We've been seeing some android GRPC issues and also discrepancies between how Android and iOS work. Lets make them more inline with each other by both using the V2 Rust functions.