Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing conversations that contain a no valid topic #138

Merged

Conversation

giovasdistillery
Copy link
Contributor

Expectations

  • Adding a filter to not show conversations that contain no valid topics
  • The filter for now is allowing alphanumeric characters and - and /

Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On your branch I got numbers around:

Loaded 2002 conversations in 17306ms

On main I got numbers around:

Loaded 2002 conversations in 17199ms

This seems to validate no performance impact. Thanks for adding the tests. LGTM!

@giovasdistillery giovasdistillery merged commit 65a3ed1 into main Nov 25, 2023
5 of 6 checks passed
@giovasdistillery giovasdistillery deleted the gg/bugfix/conversations_with_invalid_name_topics branch November 25, 2023 00:23
Copy link

gitpoap-bot bot commented Nov 25, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 XMTP Contributor:

GitPOAP: 2023 XMTP Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants