Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Application ID In Leaf Node #10

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions openmls/src/extensions/test_extensions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,54 @@ fn application_id() {
assert_eq!(&data[..], &serialized_extension_struct);
}

#[apply(ciphersuites_and_providers)]
fn application_id_in_proposals(ciphersuite: Ciphersuite, provider: &impl OpenMlsProvider) {
let extension = Extension::ApplicationId(ApplicationIdExtension::new("Bob".as_bytes()));

// Build a KeyPackage with an application id
let credential = Credential::new(b"Bob".to_vec(), CredentialType::Basic).unwrap();
let signer =
openmls_basic_credential::SignatureKeyPair::new(ciphersuite.signature_algorithm()).unwrap();

let extensions = Extensions::single(extension);
let crypto_config = CryptoConfig::with_default_version(ciphersuite);
let capabilities = Capabilities::new(
None,
None,
// Add last resort extension as supported extension
Some(&[ExtensionType::ApplicationId]),
None,
None,
);
let kp = KeyPackage::builder()
.key_package_extensions(extensions)
.leaf_node_capabilities(capabilities)
.build(
crypto_config,
provider,
&signer,
CredentialWithKey {
credential: credential.clone(),
signature_key: signer.to_public_vec().into(),
},
)
.expect("error building key package with last resort extension");
assert!(kp.extensions().application_id().is_some());
let encoded_kp = kp
.tls_serialize_detached()
.expect("error encoding key package with last resort extension");
let decoded_kp = KeyPackageIn::tls_deserialize(&mut encoded_kp.as_slice())
.expect("error decoding key package with last resort extension")
.validate(provider.crypto(), ProtocolVersion::default())
.expect("error validating key package with last resort extension");
assert!(decoded_kp.extensions().application_id().is_some());
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will pass

assert!(decoded_kp
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail

.leaf_node()
.extensions()
.application_id()
.is_some());
}

// This tests the ratchet tree extension to deliver the public ratcheting tree
// in-band
#[apply(ciphersuites_and_providers)]
Expand Down
Loading