Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optimistic sending #887

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Fix optimistic sending #887

merged 5 commits into from
Jul 8, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Jul 2, 2024

fixes #881

  • adds new send_optimistic to ffi and node bindings. send_optimistic
    • returns UnpublishedMessage with an id() function and a publish() fn.
      • publish publishes intents. if sending many messages in a row, only one publish needs to be called. Alternatively, the group can also be synced.

@insipx insipx marked this pull request as ready for review July 3, 2024 17:43
@insipx insipx requested a review from a team as a code owner July 3, 2024 17:43
@insipx insipx requested a review from richardhuaaa July 3, 2024 17:44
@insipx insipx marked this pull request as draft July 3, 2024 17:46
@insipx insipx removed the request for review from richardhuaaa July 3, 2024 17:46
@insipx insipx requested a review from richardhuaaa July 3, 2024 18:38
@insipx insipx marked this pull request as ready for review July 3, 2024 18:38
@insipx insipx merged commit d4d8134 into main Jul 8, 2024
8 checks passed
@insipx insipx deleted the insipx/fix-optimistic-send branch July 8, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix optimistic sending
2 participants