Adds the ability to add/remove admins and super admins #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
neekolas
reviewed
May 28, 2024
bindings_ffi/src/mls.rs
Outdated
|
|
||
| pub fn is_admin(&self, account_address: &String) -> Result<bool, GenericError> { | ||
| let admin_list = self.admin_list()?; | ||
| Ok(admin_list.contains(account_address)) |
There was a problem hiding this comment.
Wait. Isn't the admin list going to be defined in terms of inbox_id, not account_address?
There was a problem hiding this comment.
👍 updated a7cbdce
neekolas
reviewed
May 28, 2024
| @@ -628,6 +628,7 @@ fn extract_metadata_changes( | |||
| immutable_metadata, | |||
| old_mutable_metadata, | |||
| ), | |||
| num_super_admins: old_mutable_metadata.super_admin_list.len() as u32, | |||
There was a problem hiding this comment.
Shouldn't this be the new_mutable_metadata?
There was a problem hiding this comment.
Yea I had a check in a world where you can only remove 1 super admin at a time, that there must be more than 1 before you remove. But checking that the new mutable metadata has at least one super admin is the better option so that removing multiple superadmins would evaluate correctly as well. fixed here - d5d06f4
nplasterer
approved these changes
May 28, 2024
This was referenced May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #664
Depends on proto update:
This PR adds the following:
Before merging:
dev/gen_protos.shback tomain