Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity E2E integration #755

Merged
merged 28 commits into from
May 21, 2024

More loose ends

9714d5b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Identity E2E integration #755

More loose ends
9714d5b
Select commit
Loading
Failed to load commit list.
GitHub Actions / workspace succeeded May 20, 2024 in 1s

workspace

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.78.0 (9b00956e5 2024-04-29)
  • cargo 1.78.0 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9b00956 2024-04-29)

Annotations

Check warning on line 80 in xmtp_mls/src/identity_updates.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

question mark operator is useless here

warning: question mark operator is useless here
  --> xmtp_mls/src/identity_updates.rs:80:9
   |
80 |         Ok(self.get_association_state(conn, inbox_id, None).await?)
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `self.get_association_state(conn, inbox_id, None).await`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
   = note: `#[warn(clippy::needless_question_mark)]` on by default

Check warning on line 301 in xmtp_mls/src/groups/validated_commit.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> xmtp_mls/src/groups/validated_commit.rs:301:52
    |
301 |         let policy_set = extract_group_permissions(&openmls_group)?;
    |                                                    ^^^^^^^^^^^^^^ help: change this to: `openmls_group`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 526 in xmtp_mls/src/client.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

unneeded `return` statement

warning: unneeded `return` statement
   --> xmtp_mls/src/client.rs:526:21
    |
526 |             None => return Err(IdentityError::InstallationIdNotFound(inbox_id).into()),
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
526 |             None => Err(IdentityError::InstallationIdNotFound(inbox_id).into()),
    |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 524 in xmtp_mls/src/client.rs

See this annotation in the file changed.

@github-actions github-actions / workspace

unneeded `return` statement

warning: unneeded `return` statement
   --> xmtp_mls/src/client.rs:524:17
    |
524 |                 return Ok(inbox_id);
    |                 ^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
    |
524 -                 return Ok(inbox_id);
524 +                 Ok(inbox_id)
    |