Adding and removing group members #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tp/libxmtp into 05-01-create_validated_commit_for_mls
…ub.com:xmtp/libxmtp into 05-01-add_remove_members_using_groupmembership
neekolas
commented
May 16, 2024
| @@ -144,93 +141,6 @@ impl From<Vec<Vec<u8>>> for AddressesOrInstallationIds { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Debug, Clone)] | |||
There was a problem hiding this comment.
Adding and removing members are now handled in a single action. That way we can bundle up adding missing installations with adding a new member, as a single commit.
37ng
approved these changes
May 16, 2024
| // get current number of users in group | ||
| let member_count = self.members()?.len(); | ||
| if member_count + account_addresses.len() > MAX_GROUP_SIZE as usize { | ||
| if member_count + inbox_id_map.len() > MAX_GROUP_SIZE as usize { |
There was a problem hiding this comment.
Could multiple addresses in account_addresses link to the same inbox id so that we over-calculate the group size?
There was a problem hiding this comment.
Only until we update group.members() to be based on inbox ID. Coming very soon
Co-authored-by: 37ng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
GroupMembershipadd_missing_memberswork with the new membership primitivesNext up
group.members()from this PR. Will be updating that next