-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save group message content types #1435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
cameronvoell
changed the title
save group message content types
Save group message content types
Dec 19, 2024
cameronvoell
commented
Dec 19, 2024
This was referenced Dec 19, 2024
cameronvoell
force-pushed
the
12-18-save_group_message_content_types
branch
7 times, most recently
from
December 19, 2024 20:12
0a44516
to
2bd831a
Compare
insipx
requested changes
Dec 19, 2024
insipx
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated review
cameronvoell
force-pushed
the
12-18-save_group_message_content_types
branch
from
December 19, 2024 23:30
dc6428c
to
fbed7ce
Compare
cameronvoell
force-pushed
the
12-18-save_group_message_content_types
branch
2 times, most recently
from
December 19, 2024 23:51
ac4dbaf
to
ca5c57a
Compare
insipx
approved these changes
Dec 20, 2024
cameronvoell
force-pushed
the
12-18-save_group_message_content_types
branch
from
December 20, 2024 01:05
ca5c57a
to
247a7e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1403
Adds fields to
group_messages
table corresponding toContentTypeId
proto and saves them when sending and receiving messages.ContentTypeId
for reference:https://github.com/xmtp/proto/blob/404a0f41a6dc00f5de5fcfc24856c8b4e417fe59/proto/mls/message_contents/content.proto#L10-L16