Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide HMAC Keys #1394

Merged
merged 20 commits into from
Dec 10, 2024
Merged

Provide HMAC Keys #1394

merged 20 commits into from
Dec 10, 2024

Conversation

codabrink
Copy link
Contributor

@codabrink codabrink commented Dec 9, 2024

This provides the HMAC keys while uploading messages, and also provides the last hmac, current hmac, and next hmac on the FFI.
Issue: #1380

@codabrink codabrink changed the title Coda/provide hmac keys Provide HMAC Keys Dec 9, 2024
@codabrink codabrink marked this pull request as ready for review December 9, 2024 23:50
@codabrink codabrink requested a review from a team as a code owner December 9, 2024 23:50
Copy link
Contributor

@insipx insipx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than a couple nits!

xmtp_mls/src/constants.rs Outdated Show resolved Hide resolved
@codabrink codabrink enabled auto-merge (squash) December 10, 2024 17:13
@codabrink codabrink merged commit 0d7674e into main Dec 10, 2024
11 checks passed
@codabrink codabrink deleted the coda/provide-hmac-keys branch December 10, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants